Show favicon in tabs tray page

VERIFIED FIXED in Firefox 57

Status

()

defect
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: jwu, Assigned: jwu)

Tracking

(Blocks 2 bugs)

Trunk
Firefox 58
Unspecified
Android
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 verified, firefox58 verified)

Details

(Whiteboard: [FNC][SPT58.2][INT])

Attachments

(3 attachments)

(Assignee)

Description

2 years ago
We would like to show favicon in tabs tray page, just like Firefox for iOS. Check attachment for the visual spec.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 3

2 years ago
mozreview-review
Comment on attachment 8916477 [details]
Bug 1406338 - Part 2: Show favicons in tabs tray page.

https://reviewboard.mozilla.org/r/187596/#review192634
Attachment #8916477 - Flags: review?(cnevinchen) → review+

Comment 4

2 years ago
mozreview-review
Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

https://reviewboard.mozilla.org/r/187594/#review192636
Attachment #8916476 - Flags: review?(cnevinchen) → review+

Comment 5

2 years ago
Pushed by topwu.tw@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/ef0e62e2956d
Part 1: Support applying specific text size while creating a favicon. r=nechen
https://hg.mozilla.org/integration/autoland/rev/5e2772fd3b67
Part 2: Show favicons in tabs tray page. r=nechen
https://hg.mozilla.org/mozilla-central/rev/ef0e62e2956d
https://hg.mozilla.org/mozilla-central/rev/5e2772fd3b67
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Assignee)

Comment 7

2 years ago
Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

Approval Request Comment
[Feature/Bug causing the regression]:
Show favicon in tabs tray page

[User impact if declined]:
User cannot see favicon on tabs tray page. This patch is to keep visual consistent with Fennec iOS. We  want to uplift this patch as part of Photon related work.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
Yes, the STR is
1. Launch Fennec and press the 'tabs' button to enter tabs tray page,
2. Check if the favicon for each tab is shown correctly.

[List of other uplifts needed for the feature/fix]:
Another 1 patch needed for uplift: attachment 8916477 [details]

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
We copy the logic of favicon loading from bookmarks panel to tabs tray page. This code logic should work fine and be tested thoroughly in several releases.

[String changes made/needed]:
No
Attachment #8916476 - Flags: approval-mozilla-beta?
Verified as fixed in build 58.0a1 (2017-10-11);
Device: Sony Xperia Z5 Premium (Android 6.0.1).
Status: RESOLVED → VERIFIED
Status: VERIFIED → RESOLVED
Last Resolved: 2 years ago2 years ago
Comment on attachment 8916476 [details]
Bug 1406338 - Part 1: Support applying specific text size while creating a favicon.

Fennec Photon, Beta57+
Attachment #8916476 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Depends on: 1407915

Updated

2 years ago
Whiteboard: [FNC][SPT58.2][INT]

Comment 11

2 years ago
Verified as fixed in build 57.0b9;
Device: Pixel C (Android 7.1.1).

Updated

2 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.