1406401 - The separators from Bookmarks Toolbar cannot be moved anymore with the mouse

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[Ciprian Georgiu, Desktop QA]

Attachment: screencast showing this issue.gif

[Affected versions]:
- latest Nightly 58.0a1 (2017-10-06)
- Beta 57.0b6 (20171005195903)

[Affected platforms]:
- Mac OS X 10.10
- Windows 10 x64
- Ubuntu 16.04 x64

[Steps to reproduce]:
1. Start Firefox.
2. Open Bookmarks Toolbar.
3. Add a few separators via context menu.
4. Click on a separator and try to move its position with your mouse.

[Expected result]:
- The separators are properly moved.

[Actual result]:
- The separators cannot be moved with the mouse.

[Regression range]:
- Last good revision: 8dad665a3b1ae9c7e269fe8e401e7967b03f74ab
  First bad revision: 1654d3ffca3e79e8204b0c592f9e35d49cfd2a22
  Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=8dad665a3b1ae9c7e269fe8e401e7967b03f74ab&tochange=1654d3ffca3e79e8204b0c592f9e35d49cfd2a22

[Additional notes]:
- see the attached screencast

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

[Tracking Requested - why for this release]: Regression in optional primary UI, makes tedious to move things around in the bookmarks toolbar.

Comment 2

[Sam Foster [:sfoster] (he/him)]

My regression, I'll take this.

Comment 3

[Marcia Knous [:marcia]]

Tracking 57+. Visible regression that should be addressed as focus will be on the UI.

Comment 4

[Sam Foster [:sfoster] (he/him)]

I can't reproduce this on Ubuntu. The separators drag just fine on nightly/moz-central for me?
 
These separators are 1px wide, and the gap inbetween them and buttons is margin meaning the drag handle is pretty hard to hit. But, easier with a mouse than a trackpad I'm sure. If we consider this a useful and important feature, we might want to make that a bit bigger (move some of the margin to padding)

Comment 5

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1406401 - Dragging toolbar separators shouldnt move the window.

Review commit: https://reviewboard.mozilla.org/r/187404/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187404/

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 8916153 [details]
Bug 1406401 - Dragging toolbar separators shouldnt move the window.

https://reviewboard.mozilla.org/r/187404/#review192526

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fcc02c3f871b
Dragging toolbar separators shouldnt move the window. r=dao

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fcc02c3f871b

Comment 9

[:Gijs (he/him)]

I guess we should uplift this to 57... Sam, can you fill out a request? Thanks!

Comment 10

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 8916153 [details]
Bug 1406401 - Dragging toolbar separators shouldnt move the window.

Approval Request Comment
[Feature/Bug causing the regression]: bug 1387415 
[User impact if declined]: Unable to drag toolbar separators to move them on the toolbar
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
Show bookmarks toolbar
Right-click on the toolbar and select "New separator" 
Click on separator to move it left/right. A drop indicator should appear allowing you to move the separator along the toolbar 
[List of other uplifts needed for the feature/fix]: /
[Is the change risky?]: No
[Why is the change risky/not risky?]: One line change to exclude these separators from the window-dragging behavior. Change has very limited scope and uses an existing, well understood mechanism
[String changes made/needed]: None

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916153 [details]
Bug 1406401 - Dragging toolbar separators shouldnt move the window.

Photon related, Beta57+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/7d76e5af1c2b

Comment 13

[Sajedul Islam]

I have reproduced this bug with Nightly 58.0a1 (2017-10-06) on Windows 10 , 64 Bit ! 

This bug's fix is Verified with latest Beta & Nightly !

Build   ID    20171009192146
User Agent    Mozilla/5.0 (Windows NT 10.0; WOW64; rv:57.0) Gecko/20100101 Firefox/57.0

Build   ID    20171012105833
User Agent    Mozilla/5.0 (Windows NT 10.0; WOW64; rv:58.0) Gecko/20100101 Firefox/58.0

[bugday-20171011]

Comment 14

[Ciprian Georgiu, Desktop QA]

Thanks Sajedul for testing!

This is also verified fixed on latest Nightly 58.0a1 (2017-10-29) and Beta 57.0b12 (20171026211016) under Win 10 x64, macOS 10.13.