1406413 - TypeError: gBrowser.tabContainer is undefined every time the browser is closed (seen only in debug)

Status: RESOLVED FIXED

(Firefox :: Session Restore, enhancement, P3)

Description

[Mike Kaply [:mkaply]]

When you close the browser in debug mode, you get this message on the console:

avaScript error: chrome://browser/content/browser.js, line 8361: TypeError: gBrowser.tabContainer is undefined

The error is actually at the first line in the function removeRestoreButton:

http://searchfox.org/mozilla-central/source/browser/base/content/browser.js#8409

We should add a null check or figure out why this is failing,

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Here is where the error comes from:

TypeError: gBrowser.tabContainer is undefined
removeRestoreButton@chrome://browser/content/browser.js:8459:9
observe@chrome://browser/content/browser.js:8481:5
clear@resource:///modules/sessionstore/SessionStore.jsm:5107:7
ssi_onQuitApplication@resource:///modules/sessionstore/SessionStore.jsm:1730:7
ssi_observe@resource:///modules/sessionstore/SessionStore.jsm:788:9

This patch just prevents the notification from being fired during shutdown.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8941492 [details] [diff] [review]
Patch

Review of attachment 8941492 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c1d281ef5482
avoid notifying browser windows that we are clearing the session during shutdown, r=mikedeboer.

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c1d281ef5482