1406426 - Change "releaseChannelCollection" to "recordOnRelease"

Status: NEW

(Toolkit :: Telemetry, enhancement, P3)

Description

[Chris H-C :chutten]

Histograms.json, Scalars.yaml, MDN, and https://firefox-source-docs.mozilla.org/ all use "releaseChannelCollection" (or "release_channel_collection") with values "opt-in"/"opt-out"

This is confusing and easy to get wrong.

Let's switch it to the dynamic registration API's more comprehensible "record_on_release" nomenclature.

Open Questions:
 * Did I miss anything that mentions or uses releaseChannelCollection?
 * Should we use "recordOnRelease" (camel case) for Histograms and "record_on_release" (snake case) for everything else?

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to Chris H-C :chutten from comment #0)
> Open Questions:
>  * Did I miss anything that mentions or uses releaseChannelCollection?

Even if it's not being used in Events.yaml, events use this policy as well: http://searchfox.org/mozilla-central/rev/8efd128b48cdae3a6c6862795ce618aa1ca1c0b4/toolkit/components/telemetry/parse_events.py#123

>  * Should we use "recordOnRelease" (camel case) for Histograms and
> "record_on_release" (snake case) for everything else?

Mh, I think it makes more sense to use "record_on_release" everywhere. histogram_tools.py is using snake case inconsistently in some places anyway, and looks like "releaseChannelCollection" was more of an exception: http://searchfox.org/mozilla-central/rev/8efd128b48cdae3a6c6862795ce618aa1ca1c0b4/toolkit/components/telemetry/histogram_tools.py#29,33,35

Comment 2

[Georg Fritzsche [:gfritzsche]]

Note that this has pipeline dependencies for changes in the registry files.
There are a few data jobs that currently access these files with distributed logic.

We have two options for this:
(1) hold this until a "probe info service" is adopted
(2) make the current pipeline consumers aware of both property names

(1) is cleaner but might take a while. (2) might be more reasonable if we want to do this clean-up short-term.