Closed
Bug 1406440
Opened 7 years ago
Closed 7 years ago
don't inline nsSMILNullType::Singleton()
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
|
2.02 KB,
patch
|
dholbert
:
review+
|
Details | Diff | Splinter Review |
Defining Singleton() in the declaration of nsSMILNullType implicitly sticks an "inline" on the function, which is not what we want: inlining it spreads around a lot of static initialization code. Providing an out-of-line definition is much better in terms of code size.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8916050 -
Flags: review?(dholbert)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8916050 [details] [diff] [review] don't inline nsSMILNullType::Singleton() Review of attachment 8916050 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8916050 -
Flags: review?(dholbert) → review+
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/7fd54747a3b7 don't inline nsSMILNullType::Singleton(); r=dholbert
|
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/7fd54747a3b7
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•