1406453 - Typo in literal regular expression in toolkit/modules/addons/WebRequestContent.js

Status: RESOLVED FIXED

(WebExtensions :: Request Handling, defect, P3)

Description

[u603568]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Firefox/58.0
Build ID: 20171006100327

Steps to reproduce:

I was just informally looking at the source code at:
https://hg.mozilla.org/mozilla-central/file/tip/toolkit/modules/addons/WebRequestContent.js


Actual results:

I saw the following regular expression near the top of the file:

    const IS_HTTP = /^https?:|wss?:/;

I am pretty sure there is a typo in this regular expression. Currently, if `^https?:` is not matched, the alternative will be to scan the whole URL to find an instance of `wss?` -- though this must rarely happens, it can happen with data: URI (which can often be rather large.)


Expected results:

The intent was probably for the regular expression to be as follow:

    const IS_HTTP = /^https?:|^wss?:/;

or

    const IS_HTTP = /^(?:https?:|wss?:)/;

(whatever is best, I have no clue).

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1406453 fix http/ws regex

Review commit: https://reviewboard.mozilla.org/r/199966/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199966/

Comment 2

[Kris Maglione [:kmag]]

Comment on attachment 8928702 [details]
Bug 1406453 fix http/ws regex

https://reviewboard.mozilla.org/r/199966/#review207508

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/060e71d0f8ae
fix http/ws regex r=kmag

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/060e71d0f8ae

Comment 5

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!