1406494 - Allow specifying a resource override path

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect, P1)

Description

[Markus Stange [:mstange]]

If you want to test changes to webrender shaders, at the moment you have to rebuild Firefox in order for the shader changes to become effective.

However, webrender supports a resource_override_path setting which lets you test shader changes simply by changing the shader files and restarting the process, if the setting is set to the correct resource directory.

In this bug I'd like to add support for an environment variable WR_RESOURCE_DIR to Firefox which gets forwarded to the resource_override_path setting.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1406494 - Add a WR_RESOURCE_PATH environment variable that lets you set a resource override path for webrender.

This allows easier testing of shader changes. If you point this environment
variable at your gfx/webrender/res/ directory, the shaders will be read from
that directory when Firefox is launched, so you can test shader changes just by
restarting Firefox and don't need to recompile.

Review commit: https://reviewboard.mozilla.org/r/187328/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187328/

Comment 2

[Markus Stange [:mstange]]

I'm open to calling it WR_RESOURCE_PATH instead, in order to match the name of the webrender setting more closely.

Comment 3

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8916092 [details]
Bug 1406494 - Add a WR_RESOURCE_PATH environment variable that lets you set a resource override path for webrender.

https://reviewboard.mozilla.org/r/187328/#review192394

Comment 4

[Markus Stange [:mstange]]

Comment on attachment 8916092 [details]
Bug 1406494 - Add a WR_RESOURCE_PATH environment variable that lets you set a resource override path for webrender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187328/diff/1-2/

Comment 5

[Markus Stange [:mstange]]

I'm calling it WR_RESOURCE_PATH.

Comment 6

[Markus Stange [:mstange]]

Comment on attachment 8916092 [details]
Bug 1406494 - Add a WR_RESOURCE_PATH environment variable that lets you set a resource override path for webrender.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187328/diff/2-3/

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b67a58f0f804
Add a WR_RESOURCE_PATH environment variable that lets you set a resource override path for webrender. r=kats

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/b67a58f0f804

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c68838a2ad09
Fix spelling of the environment variable.

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/c68838a2ad09