1406631 - Remove color-picker-available system metric.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Emilio Cobos Álvarez (:emilio)]

It's always true, so there's no point in it.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1406631: Remove the color-picker-available system metric.

All our widgets support it with a constant true.

Review commit: https://reviewboard.mozilla.org/r/187464/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187464/

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

So this media feature was added in bug 936628 for Metro. And later the Metra project is dropped, and this becomes always true in bug 1039866.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8916236 [details]
Bug 1406631: Remove the color-picker-available system metric.

https://reviewboard.mozilla.org/r/187464/#review192540

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f70d6fcdb760
Remove the color-picker-available system metric. r=xidorn

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for failing color related reftests like layout/reftests/writing-mode/ua-style-sheet-input-color-1.html on Android:

https://hg.mozilla.org/integration/autoland/rev/2f7a21908e75071747d52a101abd970073f9a22a

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=24cf61e5a04fb68ecc2b41bf3e858199783c5450&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=135521643&repo=autoland

REFTEST TEST-UNEXPECTED-FAIL | http://10.0.2.2:8854/tests/layout/reftests/writing-mode/ua-style-sheet-input-color-1.html == http://10.0.2.2:8854/tests/layout/reftests/writing-mode/ua-style-sheet-input-color-1-ref.html | image comparison, max difference: 255, number of differing pixels: 8592

Comment 6

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1406631: Make input[type=color] rules consistent on Android.

Before this patch, the :-moz-system-metric pseudo-class made the
input[type="color"] rules more specific than this rule in content.css:

  * > input:not(:-moz-any([type="image"], [type="checkbox"], [type="radio"]))

After removing it, this is not the case. This seems like an accident, so let's
make input[type="color"] consistent with the rest of the buttons just the same
way as in forms.css.

Review commit: https://reviewboard.mozilla.org/r/187950/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187950/

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Attachment: Fuzzy with query: android reftest

Pushed via `mach try fuzzy`

Review commit: https://reviewboard.mozilla.org/r/187952/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187952/

Comment 8

[Emilio Cobos Álvarez (:emilio)]

Comment on attachment 8916236 [details]
Bug 1406631: Remove the color-picker-available system metric.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/187464/diff/1-2/

Comment 9

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8916910 [details]
Bug 1406631: Make input[type=color] rules consistent on Android.

https://reviewboard.mozilla.org/r/187950/#review193098

I guess this is fine.

Comment 10

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1406631: Update reftest expectations.

All the input[type="color"] reftests pass now. Only exception is the
writing-mode reftest, which has the padding hard-coded, and in Android that
padding is 7px instead of 8px.

There's a similar test for button skipped on Android, so I'm doing the same and
leaving a comment.

Review commit: https://reviewboard.mozilla.org/r/188006/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188006/

Comment 11

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8916981 [details]
Bug 1406631: Update reftest expectations.

https://reviewboard.mozilla.org/r/188006/#review193338

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4c2ed28dd016
Remove the color-picker-available system metric. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/cae6d15ae407
Make input[type=color] rules consistent on Android. r=xidorn
https://hg.mozilla.org/integration/autoland/rev/89b6554cef5e
Update reftest expectations. r=xidorn

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4c2ed28dd016
https://hg.mozilla.org/mozilla-central/rev/cae6d15ae407
https://hg.mozilla.org/mozilla-central/rev/89b6554cef5e