Closed Bug 1406662 Opened 2 years ago Closed 2 years ago

When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox58 wontfix, firefox59 fixed)

RESOLVED FIXED
mozilla59
Tracking Status
firefox58 --- wontfix
firefox59 --- fixed

People

(Reporter: sylvestre, Assigned: sylvestre)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

No description provided.
Blocks: 1378834
https://hg.mozilla.org/projects/oak/rev/ed8666ad072f62bc8ac6f4ea3770501ce76ce1cb
Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID
Blocks: 1417826
Comment on attachment 8928905 [details]
Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

https://reviewboard.mozilla.org/r/200236/#review205700

::: old-configure.in:4549
(Diff revision 1)
>    MOZ_MACBUNDLE_NAME=${MOZ_MACBUNDLE_NAME}.app
>  fi
>  AC_SUBST(MOZ_MACBUNDLE_NAME)
>  
>  dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME)
> +# If the MOZ_MACBUNDLE_ID is defined in the configure, use it

configure.sh
Attachment #8928905 - Flags: review?(mh+mozilla) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7148babfe2ab
When defined in the configure.sh, use the MOZ_MACBUNDLE_ID r=glandium
https://hg.mozilla.org/mozilla-central/rev/7148babfe2ab
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla59
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40eb00c21e7c
Defines the MOZ_MACBUNDLE_ID for nightly r=glandium
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc27374be3ad
Defines the MOZ_MACBUNDLE_ID for nightly r=glandium
Depends on: 1426743
Flags: needinfo?(sledru)
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29495c8b47f5
Remove a duplicate declaration (the first version should not have landed) r=me
https://hg.mozilla.org/integration/mozilla-inbound/rev/29495c8b47f5b4377a78b496be6beee799c0989c
Bug 1406662 - Remove a duplicate declaration (the first version should not have landed) r=me
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.