1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/projects/oak/rev/ed8666ad072f62bc8ac6f4ea3770501ce76ce1cb
Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

Preserving the MOZ_MACBUNDLE_ID will avoid issue related to bundle identifier

Review commit: https://reviewboard.mozilla.org/r/200236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/200236/

Comment 3

[Mike Hommey [:glandium]]

Comment on attachment 8928905 [details]
Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

https://reviewboard.mozilla.org/r/200236/#review205700

::: old-configure.in:4549
(Diff revision 1)
>    MOZ_MACBUNDLE_NAME=${MOZ_MACBUNDLE_NAME}.app
>  fi
>  AC_SUBST(MOZ_MACBUNDLE_NAME)
>  
>  dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME)
> +# If the MOZ_MACBUNDLE_ID is defined in the configure, use it

configure.sh

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8928905 [details]
Bug 1406662 - When defined in the configure.sh, use the MOZ_MACBUNDLE_ID

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/200236/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7148babfe2ab
When defined in the configure.sh, use the MOZ_MACBUNDLE_ID r=glandium

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/7148babfe2ab

Comment 7

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/982907bd9659732f0dc3dac67b89a5d3765a1843
Bug 1406662 - Defines the MOZ_MACBUNDLE_ID for nightly r=glandium

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/982907bd9659

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40eb00c21e7c
Defines the MOZ_MACBUNDLE_ID for nightly r=glandium

Comment 10

[Dorel Luca [:dluca]]

 Backed out changeset 40eb00c21e7c (bug 1406662) for failing Browser-chrome on toolkit/xre/test/browser_checkdllblockliststate.js on a CLOSED TREE 

https://treeherder.mozilla.org/logviewer.html#?job_id=152893594&repo=mozilla-inbound&lineNumber=6086

https://hg.mozilla.org/integration/mozilla-inbound/rev/78cd079cd2d83280576a3da2ca3776f551b91301

https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=40eb00c21e7c776d4781c28e88a9b0917b4396ce&filter-classifiedState=unclassified&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=152893594

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/cc27374be3ad
Defines the MOZ_MACBUNDLE_ID for nightly r=glandium

Comment 12

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/cc27374be3ad

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/29495c8b47f5
Remove a duplicate declaration (the first version should not have landed) r=me

Comment 14

[Sylvestre Ledru [:Sylvestre]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29495c8b47f5b4377a78b496be6beee799c0989c
Bug 1406662 - Remove a duplicate declaration (the first version should not have landed) r=me

Comment 15

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/29495c8b47f5