1406669 - ./mach lint -l flake8 is failing on some specific files (not .py?)

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

$ ./mach lint -l flake8  build/moz.configure/windows.configure 
doesn't return anything
while flake8 build/moz.configure/windows.configure  returns a bunch of stuff

$ ./mach lint -l flake8  config/mozunit.py
is working (if I introduce errors on purpose

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Andrew, does it ring a bell?

Comment 2

[Andrew Halberstadt [:ahal]]

Yeah, there's an 'extensions' key that's filtering this out in mozlint itself:
https://dxr.mozilla.org/mozilla-central/source/tools/lint/flake8.yml#30

Without this key, we'll end up passing in every file in the source tree to flake8 which is slow. Probably the easiest fix is to add 'configure' to that list.

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1406669 - Add the .configure extension to flake8 support

Review commit: https://reviewboard.mozilla.org/r/188358/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188358/

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8917354 [details]
Bug 1406669 - Add the .configure extension to flake8 support

https://reviewboard.mozilla.org/r/188358/#review193594

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0648d35fc2d8
Add the .configure extension to flake8 support r=ahal

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/0648d35fc2d8