Closed Bug 1406669 Opened 2 years ago Closed 2 years ago

./mach lint -l flake8 is failing on some specific files (not .py?)

Categories

(Firefox Build System :: Source Code Analysis, defect)

defect
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

$ ./mach lint -l flake8  build/moz.configure/windows.configure 
doesn't return anything
while flake8 build/moz.configure/windows.configure  returns a bunch of stuff

$ ./mach lint -l flake8  config/mozunit.py
is working (if I introduce errors on purpose
Andrew, does it ring a bell?
Flags: needinfo?(ahalberstadt)
Yeah, there's an 'extensions' key that's filtering this out in mozlint itself:
https://dxr.mozilla.org/mozilla-central/source/tools/lint/flake8.yml#30

Without this key, we'll end up passing in every file in the source tree to flake8 which is slow. Probably the easiest fix is to add 'configure' to that list.
Flags: needinfo?(ahalberstadt)
Assignee: nobody → sledru
Comment on attachment 8917354 [details]
Bug 1406669 - Add the .configure extension to flake8 support

https://reviewboard.mozilla.org/r/188358/#review193594
Attachment #8917354 - Flags: review?(ahalberstadt) → review+
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0648d35fc2d8
Add the .configure extension to flake8 support r=ahal
https://hg.mozilla.org/mozilla-central/rev/0648d35fc2d8
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.