1406670 - Switch to use SVG icons for the Quick Filter Bar buttons

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Richard Marti (:Paenglab)]

To look consistent in the iconography we should also use the same icons on the QFB like we use for the toolbar buttons.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: QFB-SVG.patch

I needed to make the buttons 2px taller because the icons are now really 16px.

I found that I missed to add the fill-opacity="context-fill-opacity" to the attach.svg files in the previous bugs. So, I'm fixing this here.

Comment 2

[Jorg K (CEST = GMT+2)]

Comment on attachment 8916287 [details] [diff] [review]
QFB-SVG.patch

Overall this is nice. I don't like the star, it's too fat. Can you make it a little more elegant, so that you can see the spikes/points a little better?

Also, with the paper clip in it's new form almost everywhere now, the attachments column in the thread pane looks particularly out of place :-(

Comment 3

[Richard Marti (:Paenglab)]

Attachment: hollow-star.png

The star is the original bookmark star from m-c. I thought you come with this. ;)

What do you think about the hollow star? This makes the icon lighter.

Comment 4

[Jorg K (CEST = GMT+2)]

(In reply to Richard Marti (:Paenglab) from comment #3)
> The star is the original bookmark star from m-c. I thought you come with
> this. ;)
Right. I can see the bookmark star, but it's in the context of other fat icons. Do we need to use that star or could it be a little thinner?

> What do you think about the hollow star? This makes the icon lighter.
Yes, but I'd still prefer a filled one.

Maybe just attach the SVG instead of the entire patch. There are heaps of 5 pointed stars online:
https://www.google.com.au/search?q=5+pointed+star
Most are derived by just connecting the five corners, but I guess you can make it a little thicker, like:
https://cdn3.iconfinder.com/data/icons/stars-shards/100/Star__5_point_filled-512.png

Comment 5

[Richard Marti (:Paenglab)]

Attachment: QFB-SVG.patch

Patch with the bigger version of flag-col.svg as the star icon. With this we are consistent with the tree-col icon. ;)

Comment 6

[Jorg K (CEST = GMT+2)]

Comment on attachment 8916294 [details] [diff] [review]
QFB-SVG.patch

Yes, this star is very good indeed!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/48a4c3f584cc
Use SVG icons for the QFB bar. r=jorgk