1406689 - PDFs should just go to ibooks unmodified

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, enhancement, P1)

Description

[Nick Nguyen [:osunick]]

In safari I can pass a PDF to iBooks unmodified whereas in Firefox it seems to print the PDF to another PDF which breaks formatting. Can we just do what Safari does?

Comment 1

[:garvan]

If the 'Open In...' bar is tapped, the PDF is saved to the filesystem and UIDocumentInteractionController is used to share the file to iBooks unmodified.

If the 'Open PDF in iBooks' share/action sheet action is used, the current document gets printed to PDF and opened. This uses UIPrintInfo/UIPrintPageRenderer as an activityItem passed to the UIActivityViewController init.
Without exposing an activity item that has print capabilities, share to iBooks doesn't show. In this case, iBooks sharing is side-effect of being able to print the document.

I see mention of developers making their own wrapper extension that can handle this case, which is a heavy approach.

Chrome iOS follows the first method only (a similar helper toolbar is shown), and doesn't allow opening PDFs in iBooks using share/action menu.

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

Comment 3

[Justin D'Arcangelo [:justindarc]]

Comment on attachment 8975167 [details] [review]
GitHub Pull Request

Carrying over R+ from GitHub.

Comment 4

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/48b96e7992424f53127c3480c2835deadd6c45c0