1406695 - Tests should fail if a browser.test.onMessage handler throws an error in tests

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P5)

Description

[Masatoshi Kimura [:emk]]

Currently tests will just hang up and timeout because applySafe will swallow exceptions.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Bug 1406695 - Fail if a browser.test.onMessage handler throws an error.

Review commit: https://reviewboard.mozilla.org/r/187526/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187526/

Comment 2

[Andrew Swan [:aswan]]

Comment on attachment 8916317 [details]
Bug 1406695 - Fail if a browser.test.onMessage handler throws an error.

https://reviewboard.mozilla.org/r/187526/#review193798

This looks good, thank you!  But please to a thorough try run (at least toolkit/components/extensions, browser/components/extensions, and mobile/android/components/extensions) before landing.

Comment 3

[Masatoshi Kimura [:emk]]

I already run a try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=99f0882c266eaeb4f70331fdfde548d68d6bcc8a
https://treeherder.mozilla.org/#/jobs?repo=try&revision=aac7223ef6afb19a6deb72209e8bfb4b3392f991

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6f83e51a6d78
Fail if a browser.test.onMessage handler throws an error. r=aswan

Comment 5

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6f83e51a6d78

Comment 6

[Caitlin Neiman [:caitmuenster]]

Thanks so much, Masatoshi! Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#October_2017

I look forward to seeing you around. :)

Comment 7

[CosminB]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!