Tests should fail if a browser.test.onMessage handler throws an error in tests

RESOLVED FIXED in Firefox 58

Status

enhancement
P5
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: emk, Assigned: emk)

Tracking

(Depends on 1 bug)

unspecified
mozilla58
Points:
---
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox57 wontfix, firefox58 fixed)

Details

Attachments

(1 attachment)

Currently tests will just hang up and timeout because applySafe will swallow exceptions.
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Priority: -- → P5
Comment on attachment 8916317 [details]
Bug 1406695 - Fail if a browser.test.onMessage handler throws an error.

https://reviewboard.mozilla.org/r/187526/#review193798

This looks good, thank you!  But please to a thorough try run (at least toolkit/components/extensions, browser/components/extensions, and mobile/android/components/extensions) before landing.
Attachment #8916317 - Flags: review?(aswan) → review+
Pushed by VYV03354@nifty.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/6f83e51a6d78
Fail if a browser.test.onMessage handler throws an error. r=aswan
https://hg.mozilla.org/mozilla-central/rev/6f83e51a6d78
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Thanks so much, Masatoshi! Your contribution has been added to our recognition wiki: https://wiki.mozilla.org/Add-ons/Contribute/Recognition#October_2017

I look forward to seeing you around. :)
Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!
Flags: needinfo?(VYV03354)
Flags: needinfo?(VYV03354) → qe-verify-
Depends on: 1428213
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.