support adding further information in commit message of |./mach try empty| like "CLOSED TREE"

RESOLVED FIXED in mozilla58

Status

task
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: aryx, Assigned: ahal)

Tracking

(Blocks 1 bug)

unspecified
mozilla58
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Today Try was closed, informing developers that they can push with "CLOSED TREE" in the commit message but might have to perform further actions (retrigger a task). |./mach try empty| doesn't seem to let the developer add these keywords to the generated commit with the Try syntax.

Maybe a command line argument whose value would be added as prefix or suffix would do it?
There's an existing argument for |mach try fuzzy| and |mach try syntax| to do this. We should just get |mach try empty| to use the base argument parser.
Assignee: nobody → ahalberstadt
Status: NEW → ASSIGNED
Comment on attachment 8917528 [details]
Bug 1406777 - Support --message and --no-push with |mach try empty|,

Not currently working on Mozilla things, can you find someone else to review this?
Flags: needinfo?(ahalberstadt)
Attachment #8917528 - Flags: review?(kwierso)
Attachment #8917528 - Flags: review?(armenzg)
No problem!
Flags: needinfo?(ahalberstadt)
Comment on attachment 8917528 [details]
Bug 1406777 - Support --message and --no-push with |mach try empty|,

https://reviewboard.mozilla.org/r/188488/#review194064

lgtm
Attachment #8917528 - Flags: review?(armenzg) → review+
Pushed by ahalberstadt@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6e3a0b791182
Support --message and --no-push with |mach try empty|, r=armenzg
https://hg.mozilla.org/mozilla-central/rev/6e3a0b791182
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Hi Andrew, looks like this broke cram try: https://treeherder.mozilla.org/logviewer.html#?job_id=136758484&repo=mozilla-central
Please investigate.

[task 2017-10-13T09:07:04.223Z] x86_64-linux-gnu-gcc -pthread -shared -Wl,-O1 -Wl,-Bsymbolic-functions -Wl,-Bsymbolic-functions -Wl,-z,relro -fno-strict-aliasing -DNDEBUG -g -fwrapv -O2 -Wall -Wstrict-prototypes -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security -Wl,-Bsymbolic-functions -Wl,-z,relro -Wdate-time -D_FORTIFY_SOURCE=2 -g -fstack-protector-strong -Wformat -Werror=format-security build/temp.linux-x86_64-2.7/psutil/_psutil_posix.o -o build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so
[task 2017-10-13T09:07:04.223Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_linux.so -> psutil
[task 2017-10-13T09:07:04.223Z] copying build/lib.linux-x86_64-2.7/psutil/_psutil_posix.so -> psutil
[task 2017-10-13T09:07:04.223Z] 
[task 2017-10-13T09:07:04.281Z] cat: backend.TestManifestBackend.in: No such file or directory
[task 2017-10-13T09:07:04.287Z] Build configuration changed. Regenerating backend.
[task 2017-10-13T09:07:04.585Z] No build detected, test metadata may be incomplete.
[task 2017-10-13T09:07:04.754Z] Usage: cram [OPTIONS] TESTS...
Flags: needinfo?(ahalberstadt)
Doh, I accidentally put "DONTBUILD" in my commit message but meant to add "CLOSED TREE" as the example so jobs didn't run on my push. However, it looks like this 'try' failure is permafail but it didn't get regressed by this push. Here's the push right after mine showing a green 'try':
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=77cfd15e655674afc0553928c1b40cbd4e4ddbbc&filter-searchStr=try

I'll do some backfilling and see if I can hunt down the push that regressed this.
Flags: needinfo?(ahalberstadt)
Just from looking at the pushlog, I'm 95% sure it was regressed by bug 1407468. I'll wait for confirmation and post over there.
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.