1406794 - Provide the CSP keywords in both UTF8 and UTF16 forms

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P2)

Description

[Nicholas Nethercote [inactive]]

This avoids the need for numerous 8-to-16-bit and 16-to-8-bit string
conversions.

The patch also introduces a higher-order macro, FOR_EACH_CSP_KEYWORD, which
defines all the stuff about the keywords in a single place and makes the code
nicer.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Provide the CSP keywords in both UTF8 and UTF16 forms

I originally did this because a while back I did some basic profiling of
utf8-to-utf16 and utf16-to-utf8 conversions and the "'nonce-" keyword was
coming up a lot.

Re-measuring recently that seems to have gone away, but I still think this
change makes the code nicer and so is worth landing for that reason.

Comment 2

[Nicholas Nethercote [inactive]]

Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db9a374902982ee4856404690fec1b1701fbe098

Comment 3

[Christoph Kerschbaumer [:ckerschb}]

Comment on attachment 8916450 [details] [diff] [review]
Provide the CSP keywords in both UTF8 and UTF16 forms

Review of attachment 8916450 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing that; I like that change. r=me

Comment 4

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0ad3dbf357a122d780925cc0981f3d4deb259a
Bug 1406794 - Provide the CSP keywords in both UTF8 and UTF16 forms. r=ckerschb

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0ad3dbf357
Provide the CSP keywords in both UTF8 and UTF16 forms. r=ckerschb

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bd0ad3dbf357