Closed
Bug 1406794
Opened 7 years ago
Closed 7 years ago
Provide the CSP keywords in both UTF8 and UTF16 forms
Categories
(Core :: DOM: Security, enhancement, P2)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla58
Tracking | Status | |
---|---|---|
firefox58 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
(Whiteboard: [domsecurity-active])
Attachments
(1 file)
18.25 KB,
patch
|
ckerschb
:
review+
|
Details | Diff | Splinter Review |
This avoids the need for numerous 8-to-16-bit and 16-to-8-bit string conversions. The patch also introduces a higher-order macro, FOR_EACH_CSP_KEYWORD, which defines all the stuff about the keywords in a single place and makes the code nicer.
Assignee | ||
Comment 1•7 years ago
|
||
I originally did this because a while back I did some basic profiling of utf8-to-utf16 and utf16-to-utf8 conversions and the "'nonce-" keyword was coming up a lot. Re-measuring recently that seems to have gone away, but I still think this change makes the code nicer and so is worth landing for that reason.
Attachment #8916450 -
Flags: review?(ckerschb)
Assignee | ||
Comment 2•7 years ago
|
||
Try looks good: https://treeherder.mozilla.org/#/jobs?repo=try&revision=db9a374902982ee4856404690fec1b1701fbe098
Comment 3•7 years ago
|
||
Comment on attachment 8916450 [details] [diff] [review] Provide the CSP keywords in both UTF8 and UTF16 forms Review of attachment 8916450 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for doing that; I like that change. r=me
Attachment #8916450 -
Flags: review?(ckerschb) → review+
Updated•7 years ago
|
Priority: -- → P2
Whiteboard: [domsecurity-active]
Assignee | ||
Comment 4•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0ad3dbf357a122d780925cc0981f3d4deb259a Bug 1406794 - Provide the CSP keywords in both UTF8 and UTF16 forms. r=ckerschb
Pushed by nnethercote@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bd0ad3dbf357 Provide the CSP keywords in both UTF8 and UTF16 forms. r=ckerschb
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd0ad3dbf357
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•