Open
Bug 1406814
Opened 7 years ago
Updated 2 years ago
urlbar in chromeless popups looks as if the content is editable
Categories
(Firefox :: Theme, defect, P3)
Tracking
()
NEW
Tracking | Status | |
---|---|---|
firefox57 | --- | fix-optional |
firefox58 | --- | affected |
People
(Reporter: bram, Unassigned)
References
Details
(Whiteboard: [reserve-photon-visual])
Attachments
(1 file)
59 bytes,
text/x-review-board-request
|
Details |
chromeless urlbar should visually indicate it’s not editable, as shown in the mockup: http://mozilla.invisionapp.com/share/VGBXYQ8WF I think it’s a simple bgcolor value tweak, and will ask the Photon team for advice as to the precise colour value to use.
Reporter | ||
Updated•7 years ago
|
Severity: normal → enhancement
Priority: -- → P3
Comment 1•7 years ago
|
||
This was dropped from bug 1368460 according to this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1368460#c12 This is Windows only, right? On OSX the urlbar looks fine to me.
Blocks: 1368460
status-firefox57:
--- → fix-optional
status-firefox58:
--- → affected
Flags: qe-verify+
OS: Unspecified → Windows
Comment 2•7 years ago
|
||
(In reply to Johann Hofmann [:johannh] from comment #1) > This is Windows only, right? On OSX the urlbar looks fine to me. The urlbar looks editable on OSX in light theme. That needs to change too, I think.
Updated•7 years ago
|
OS: Windows → All
Comment 3•7 years ago
|
||
Photon is basically done as far as 57 is concerned, but we can keep track of this for 58.
Whiteboard: [reserve-photon-visual]
Updated•7 years ago
|
Assignee: nobody → dharvey
Comment hidden (mozreview-request) |
Comment 5•7 years ago
|
||
Not 100% sure this is the correct fix, I believe we are supposed to avoid :not's? but at the same time I cant think of a particularly cleaner fix
Comment 6•7 years ago
|
||
Changing priority so it orders correctly since its assigned
Priority: P3 → P1
Updated•6 years ago
|
Priority: P1 → P3
Updated•6 years ago
|
Attachment #8930134 -
Flags: review?(dao+bmo)
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•