1406814 - urlbar in chromeless popups looks as if the content is editable

Status: NEW

(Firefox :: Theme, defect, P3)

Description

[Bram Pitoyo [:bram]]

chromeless urlbar should visually indicate it’s not editable, as shown in the mockup:
http://mozilla.invisionapp.com/share/VGBXYQ8WF

I think it’s a simple bgcolor value tweak, and will ask the Photon team for advice as to the precise colour value to use.

Comment 1

[Johann Hofmann [:johannh]]

This was dropped from bug 1368460 according to this comment: https://bugzilla.mozilla.org/show_bug.cgi?id=1368460#c12

This is Windows only, right? On OSX the urlbar looks fine to me.

Comment 2

[:prathiksha]

(In reply to Johann Hofmann [:johannh] from comment #1)

> This is Windows only, right? On OSX the urlbar looks fine to me.

The urlbar looks editable on OSX in light theme. That needs to change too, I think.

Comment 3

[Dão Gottwald [:dao]]

Photon is basically done as far as 57 is concerned, but we can keep track of this for 58.

Comment 4

[Dale Harvey (:daleharvey)]

Attachment: Bug 1406814 - Avoid theme color overriding readonly style.

Review commit: https://reviewboard.mozilla.org/r/201304/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/201304/

Comment 5

[Dale Harvey (:daleharvey)]

Not 100% sure this is the correct fix, I believe we are supposed to avoid :not's? but at the same time I cant think of a particularly cleaner fix

Comment 6

[Dale Harvey (:daleharvey)]

Changing priority so it orders correctly since its assigned

Comment 7

[Dale Harvey (:daleharvey)]

Unassigning for parental leave