1406828 - (photon) (RTL) Back/forward buttons aren't Photon style on 4.2 tablet when RTL is enabled

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Jing-wei Wu [:jwu]]

Attachment: back/forward buttons on tablet

Devices:
Nexus 10 emulator (Android 4.2)

Build: Nightly

Steps to reproduce:
1. On a tablet device, set the browser language to an RTL supported language.

Expected result:
The back/forward buttons aren't Photon style.

Actual result:
The back/forward buttons should be Photon style.

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1406828 - Update back/forward icons for RTL on tablet.

Review commit: https://reviewboard.mozilla.org/r/187636/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187636/

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8916493 [details]
Bug 1406828 - Update back/forward icons for RTL on tablet.

https://reviewboard.mozilla.org/r/187636/#review192638

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71d6058e889b
Update back/forward icons for RTL on tablet. r=nechen

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/71d6058e889b

Comment 5

[Jing-wei Wu [:jwu]]

Comment on attachment 8916493 [details]
Bug 1406828 - Update back/forward icons for RTL on tablet.

Approval Request Comment
[Feature/Bug causing the regression]:
Update back/forward icons for RTL on tablet

[User impact if declined]:
This is a visual enhancement as part of Photon related UI bug.

[Is this code covered by automated tests?]:
No

[Has the fix been verified in Nightly?]:
Not yet

[Needs manual test from QE? If yes, steps to reproduce]: 
No, we just update several back/forward icons. No code logic or UI layout changed.

[List of other uplifts needed for the feature/fix]:
None

[Is the change risky?]:
No

[Why is the change risky/not risky?]:
We just change images for back/forward icons on tablet.

[String changes made/needed]:
No

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8916493 [details]
Bug 1406828 - Update back/forward icons for RTL on tablet.

Fennec photon, Beta57+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/b619b2660aa8

Comment 8

[Oana Horvath [:ohorvath]]

Verified as fixed on both latest Nightly and beta (57.0b9).
Devices:
Lenovo Yoga Tablet 2 (Android 4.4.2)
Asus ZenPad 8.0 Z380KL (Android 6.0.1)