140683 - No 256 color support

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Alvaro R. Perez]

My system is setup for 1024 x 768 256 colors .
Mozilla browser displays the Web page as 1024 x 768 16 colors.
I test it by loading Netscape ver 4.61 for OS/2 and loading the same Web page
with both browsers and Mozilla Ver 
Mozilla 0.9.9+
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:0.9.9+) Gecko/20020426
and Mozilla always displayed the page in 16 colors.
Thanks

Comment 1

[Mike Kaply [:mkaply]]

This probably won't make Mozilla 1.0.

We have very few users using 256 colors.

Comment 2

[amutch]

This looks like a dupe of 88560:

Major jpeg display/dithering problem on NT w/ 256 colors.
http://bugzilla.mozilla.org/show_bug.cgi?id=88560

Comment 3

[Mike Kaply [:mkaply]]

OS/2 will require custom code for this separate from the Windows code

Comment 4

[Mike Kaply [:mkaply]]

*** Bug 95167 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Kaply [:mkaply]]

Attachment: 256 color support

First pass at 256 color.

Only outstanding problem is that entryfields are missing their lower right
lines.

Working.

Comment 6

[Mike Kaply [:mkaply]]

Attachment: Final patch

Note this slows down the browser considerably.

Welcome to 256 color.

Comment 7

[jhp (no longer active)]

Comment on attachment 111408 [details] [diff] [review]
Final patch

> +  mIsPaletteDevice = !!(alArray[CAPS_ADDITIONAL_GRAPHICS] & CAPS_PALETTE_MANAGER);
Don't like this syntax.  I think it would be much clearer if you explicitly
checked to see if it was equal to a given value (i.e. "a & b == 0x001").

Otherwise, r=pedemont

Comment 8

[aaronr]

I disagree.  If you see the 0x0001, then you have no idea what it means.  Here I
know what exactly he is testing.  But it is ugly.  Maybe a nice comment above
the line?  Notnot'ing is icky!

Comment 9

[Mike Kaply [:mkaply]]

Fixed. We're slow but pretty.