Closed Bug 140683 Opened 20 years ago Closed 19 years ago

No 256 color support

Categories

(SeaMonkey :: General, defect)

Other
OS/2
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: arperez, Assigned: mkaply)

References

Details

Attachments

(1 file, 1 obsolete file)

My system is setup for 1024 x 768 256 colors .
Mozilla browser displays the Web page as 1024 x 768 16 colors.
I test it by loading Netscape ver 4.61 for OS/2 and loading the same Web page
with both browsers and Mozilla Ver 
Mozilla 0.9.9+
Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:0.9.9+) Gecko/20020426
and Mozilla always displayed the page in 16 colors.
Thanks
This probably won't make Mozilla 1.0.

We have very few users using 256 colors.
Assignee: Matti → mkaply
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: colors not displayed correctly → No 256 color support
This looks like a dupe of 88560:

Major jpeg display/dithering problem on NT w/ 256 colors.
http://bugzilla.mozilla.org/show_bug.cgi?id=88560
OS/2 will require custom code for this separate from the Windows code
*** Bug 95167 has been marked as a duplicate of this bug. ***
Attached patch 256 color support (obsolete) — Splinter Review
First pass at 256 color.

Only outstanding problem is that entryfields are missing their lower right
lines.

Working.
Attached patch Final patchSplinter Review
Note this slows down the browser considerably.

Welcome to 256 color.
Attachment #110824 - Attachment is obsolete: true
Attachment #111408 - Flags: review?(pedemont)
Comment on attachment 111408 [details] [diff] [review]
Final patch

> +  mIsPaletteDevice = !!(alArray[CAPS_ADDITIONAL_GRAPHICS] & CAPS_PALETTE_MANAGER);
Don't like this syntax.  I think it would be much clearer if you explicitly
checked to see if it was equal to a given value (i.e. "a & b == 0x001").

Otherwise, r=pedemont
Attachment #111408 - Flags: review?(pedemont) → review+
I disagree.  If you see the 0x0001, then you have no idea what it means.  Here I
know what exactly he is testing.  But it is ugly.  Maybe a nice comment above
the line?  Notnot'ing is icky!
Fixed. We're slow but pretty.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.