1406890 - Fix detection for Baum Cobra for 64 bit Firefox

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement, P2)

Description

[James Teh [:Jamie]]

Our Compatibility code tests for OsmHooks.dll to detect Baum Cobra. A contact at Baum informed me that the 64 bit dll is called OsmHks64.dll. We should update this code accordingly.

It's probably also worth checking whether this needs to be updated for any other clients we know about. It's definitely already correct for NVDA and JAWS. In particular, the "32" in gwm32inc (WE) and STSA32 (SEROTEK) suggests the 64 bit dll might be named differently, though this isn't necessarily true.

Comment 1

[James Teh [:Jamie]]

RPC_E_CANTCALLOUT_ININPUTSYNCCALL is causing problems for Cobra 64 bit. A Baum engineer confirmed that all works as expected with Cobra 32 bit. I've written the (trivial) patch and the engineer agreed to test a try build to verify the fix.

Let's restrict the scope of this bug to Cobra 64 bit, since we have a real world problem report and easy path to verification. We can deal with other 64 bit client detection in separate bugs as necessary.

Comment 2

[James Teh [:Jamie]]

Attachment: Bug 1406890: Fix detection for Baum Cobra in 64 bit processes.

The Compatibility code previously only tested for OsmHooks.dll to detect Baum Cobra.
However, the 64 bit dll is called OsmHks64.dll.
Update the code to test for both so that detection works in 64 bit processes.
Aside from telemetry, this is also needed to ensure that the InSendMessageEx hook is used to work around RPC_E_CANTCALLOUT_ININPUTSYNCCALL.

Review commit: https://reviewboard.mozilla.org/r/199396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199396/

Comment 3

[James Teh [:Jamie]]

Our contact at Baum confirmed the fix in the try build I provided.

Comment 4

[Marco Zehe (:MarcoZ)]

Comment on attachment 8928151 [details]
Bug 1406890: Fix detection for Baum Cobra in 64 bit processes.

https://reviewboard.mozilla.org/r/199396/#review204472

r=me, thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e71178cc8ba1
Fix detection for Baum Cobra in 64 bit processes. r=MarcoZ

Comment 6

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/e71178cc8ba1