Closed Bug 1406900 Opened 7 years ago Closed 7 years ago

Devirtualize RunState

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox57 --- wontfix
firefox58 --- fixed

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

(Keywords: perf, Whiteboard: [js:tech-debt])

Attachments

(1 file)

Patch
3.42 KB, patch
luke
: review+
Details | Diff | Splinter Review
Attached patch Patch — — Splinter Review
Profiler shows time in InvokeState::setReturnValue. This just devirtualizes setReturnValue and pushInterpreterFrame (the other virtual method on RunState).
Attachment #8916572 - Flags: review?(luke)
Attachment #8916572 - Flags: review?(luke) → review+
status-firefox57: --- → wontfix
Keywords: perf
Priority: -- → P3
Whiteboard: [js:tech-debt]
https://hg.mozilla.org/mozilla-central/rev/3029acae6f82
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox58: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: