Closed
Bug 1406902
Opened 7 years ago
Closed 7 years ago
wasm: don't check for MAGIC values in the return path in the wasm->jit exit
Categories
(Core :: JavaScript Engine: JIT, enhancement, P3)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla58
| Tracking | Status | |
|---|---|---|
| firefox58 | --- | fixed |
People
(Reporter: bbouvier, Assigned: bbouvier)
Details
Attachments
(1 file)
|
2.91 KB,
patch
|
luke
:
review+
|
Details | Diff | Splinter Review |
Jan said on irc this morning it shouldn't be needed (now that throwing in the js function unwinds up to the wasm frame). And a try build confirms this: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbf93ec91cd04875416d6b59e3e75d1137f7f426 That's an easy win!
Attachment #8916573 -
Flags: review?(luke)
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
|
||
Comment 1•7 years ago
|
||
Comment on attachment 8916573 [details] [diff] [review] simplify.patch Review of attachment 8916573 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8916573 -
Flags: review?(luke) → review+
Pushed by bbouvier@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6e336c49b6e7 Remove the magic value check in the wasm->jit import exit; r=luke
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
||
Comment 3•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/6e336c49b6e7
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in
before you can comment on or make changes to this bug.
Description
•