1406915 - Convert use of deprecated-sync-thenables.js (and defer) to new Promise in devtools/shared/client/

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Comment 1

[tera_1225]

Hi Nicolas.
I'll take a shot at this if you'd like. Should be rather straight forward I think... Or have you already got to work on it?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Sorry I'm working on it (and have a patch). I thought it was simple but there are some gotchas :)
Maybe you can have a look at https://bugzilla.mozilla.org/show_bug.cgi?id=1366531 ? It is similar and there was already a patch submitted on it which should make it easier to work on.

Comment 3

[tera_1225]

Sure no problem, thought I'd ask but I expected as you created the bug you'd be on it already. I'll take a look at the other one you mentioned.

Comment 5

[Patrick Brosset <:pbro>]

Talked to Niolas. This isn't a P1.

Comment 6

[Sebastian Zartner [:sebo]]

Nicolas, because there was no activity for more than a year, I unassigned this bug from you and set the priority to P3. Hope that's ok.

Sebastian

Comment 7

[Panos Astithas (he/him) [:past] (please ni?)]

Attachment: Bug 1406915 - Convert uses of defer to DOM promises in devtools/shared/client/. r=jdescottes

Comment 8

[Panos Astithas (he/him) [:past] (please ni?)]

The removal of deprecated-sync-thenables.js happened in bug 1233891, this patch is just for the remaining uses of defer() in this folder. Try was green (modulo some known intermittents):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b62a8a263a1a2d8b3c1a56bc5945504e0a38f956

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/50dbb1decae3
Convert uses of defer to DOM promises in devtools/shared/client/. r=jdescottes

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/50dbb1decae3