Closed Bug 1406915 Opened 2 years ago Closed 5 months ago

Convert use of deprecated-sync-thenables.js (and defer) to new Promise in devtools/shared/client/

Categories

(DevTools :: General, defect, P3)

defect

Tracking

(firefox57 wontfix, firefox58 wontfix, firefox70 fixed)

RESOLVED FIXED
Firefox 70
Tracking Status
firefox57 --- wontfix
firefox58 --- wontfix
firefox70 --- fixed

People

(Reporter: nchevobbe, Assigned: past)

References

Details

Attachments

(1 file)

No description provided.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Priority: -- → P1
Blocks: 881050
No longer blocks: 1283869
Hi Nicolas.
I'll take a shot at this if you'd like. Should be rather straight forward I think... Or have you already got to work on it?
Sorry I'm working on it (and have a patch). I thought it was simple but there are some gotchas :)
Maybe you can have a look at https://bugzilla.mozilla.org/show_bug.cgi?id=1366531 ? It is similar and there was already a patch submitted on it which should make it easier to work on.
Sure no problem, thought I'd ask but I expected as you created the bug you'd be on it already. I'll take a look at the other one you mentioned.
Duplicate of this bug: 1408164
Talked to Niolas. This isn't a P1.
Priority: P1 → P2
Product: Firefox → DevTools
Nicolas, because there was no activity for more than a year, I unassigned this bug from you and set the priority to P3. Hope that's ok.

Sebastian
Assignee: nchevobbe → nobody
Status: ASSIGNED → NEW
Priority: P2 → P3
Assignee: nobody → past
Status: NEW → ASSIGNED

The removal of deprecated-sync-thenables.js happened in bug 1233891, this patch is just for the remaining uses of defer() in this folder. Try was green (modulo some known intermittents):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b62a8a263a1a2d8b3c1a56bc5945504e0a38f956

Pushed by pastithas@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50dbb1decae3
Convert uses of defer to DOM promises in devtools/shared/client/. r=jdescottes
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.