Closed Bug 1406941 Opened 2 years ago Closed 9 months ago

Write unittest for configuring AudioConduit

Categories

(Core :: WebRTC: Audio/Video, enhancement, P3)

58 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla65
Tracking Status
firefox58 --- affected
firefox65 --- fixed

People

(Reporter: pehrsons, Assigned: dminor)

References

(Blocks 1 open bug)

Details

Attachments

(7 files)

Configure AudioConduit similar to how our signaling layer does it, and see that we call into a mocked encoder stack with the right values.

Repeat for different signaling properties, like fec and dtmf. See AudioCodecConfig.
Depends on: 1425039
Now that AudioConduit is using the Call interface this is much more tractable.
Assignee: nobody → dminor
With the branch 64 update we no longer configure packet size and rate
ourselves. Instead, we use the defaults provided in acm_codec_database.cc.
This removes the unused fields from AudioCodecConfig, the next commit does the
same thing for JsepAudioCodecDescription.
Packet size and rate are no longer configured inside AudioConduit, so there is
no reason to continue to define them here. We now take the defaults provided
by webrtc.org.

Depends on D12012
This was regressed by the branch 64 update. The parameter is used in
audio_encoder_opus.cc.

Depends on D12014
Rather than returning an error, the channel proxies have asserts that the
underlying calls to the channel objects succeeded.

Depends on D12015
This makes Init and DeleteChannels virtual and mRecvChannelProxy and
mSendChannelProxy protected. This will allow unit test code to override
the creation of channels so that we can use a mocked ChannelProxy instead.

Depends on D12016
Pushed by dminor@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4a979a79984c
Remove unused fields from AudioCodecConfig; r=padenot
https://hg.mozilla.org/integration/autoland/rev/d08645c75175
Remove unused fields from JsepAudioCodecDescription; r=bwc
https://hg.mozilla.org/integration/autoland/rev/c99a8cc72471
Fix typo in videoconduit_unittests.cpp; r=padenot
https://hg.mozilla.org/integration/autoland/rev/c0f52a7424de
Set opus maxplaybackrate in AudioConduit; r=padenot
https://hg.mozilla.org/integration/autoland/rev/3f0b3e4421c0
Remove unused error handling code from SetLocalRTPExtensions; r=padenot
https://hg.mozilla.org/integration/autoland/rev/0968b25b736f
Make AudioConduit more easily unit testable; r=padenot
https://hg.mozilla.org/integration/autoland/rev/d68e7e8e1db2
Add unittests for configuring AudioConduit; r=padenot
You need to log in before you can comment on or make changes to this bug.