Closed Bug 1407007 Opened 7 years ago Closed 7 years ago

[RTL] Search icon badges on the search bar are aligned to the left instead of right

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 58
Tracking Status
firefox-esr52 --- unaffected
firefox56 --- unaffected
firefox57 --- verified
firefox58 --- verified

People

(Reporter: itiel_yn8, Assigned: daleharvey)

References

Details

(Keywords: regression, Whiteboard: [reserve-photon-visual])

Attachments

(3 files)

This started a few days ago.
See attached, the small arrow icon is overlapping the search icon and the green plus sign is on the wrong side of the icon.
Previous implementation was okay in this regard. Also attached.
Attached image Old icons
Dão or Johann, do you know what might have broken this? I recall there were a few changes with the search icons that could be responsible here?
Flags: needinfo?(jhofmann)
Flags: needinfo?(dao+bmo)
Whiteboard: [photon-visual][triage]
Sounds like bug 1403359. Dale, can you confirm? :)
Flags: needinfo?(jhofmann) → needinfo?(dharvey)
Yup, will take cheers
Assignee: nobody → dharvey
Flags: needinfo?(dharvey)
Flags: needinfo?(dao+bmo)
Comment on attachment 8916943 [details]
Bug 1407007 - Fix RTL alignment of search icon.

Not ready yet
Attachment #8916943 - Flags: review?(dao+bmo)
Comment on attachment 8916943 [details]
Bug 1407007 - Fix RTL alignment of search icon.

Actual false alert, I think this is good now
Attachment #8916943 - Flags: review?(dao+bmo)
Blocks: 1403359
Whiteboard: [photon-visual][triage] → [reserve-photon-visual]
Comment on attachment 8916943 [details]
Bug 1407007 - Fix RTL alignment of search icon.

https://reviewboard.mozilla.org/r/187980/#review193142
Attachment #8916943 - Flags: review?(dao+bmo) → review+
Pushed by dharvey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2f5f7289c2d5
Fix RTL alignment of search icon. r=dao
Status: NEW → ASSIGNED
Priority: -- → P1
Flags: qe-verify+
Comment on attachment 8916943 [details]
Bug 1407007 - Fix RTL alignment of search icon.

Approval Request Comment
[Feature/Bug causing the regression]: https://bugzilla.mozilla.org/show_bug.cgi?id=1403359
[User impact if declined]: RTL users will have visually incorrect icon
[Is this code covered by automated tests?]: nope
[Has the fix been verified in Nightly?]:
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]:
[Is the change risky?]: Nope
[Why is the change risky/not risky?]: Updating missing CSS for RTL only
[String changes made/needed]:
Attachment #8916943 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/2f5f7289c2d5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Comment on attachment 8916943 [details]
Bug 1407007 - Fix RTL alignment of search icon.

Recent regression related to photon changes, Beta57+
Attachment #8916943 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Verified fixed on latest Nightly.
Status: RESOLVED → VERIFIED
I tried to recreate this bug using Nightly 58 from 2017-10-09 on WIndows 10x64, Mac OS X 10.11 and Ubuntu 16.04x64, but I couldn't reproduce it. 
The icon that I was inspecting was from the search bar (I added it back on the toolbar). But the badges were always aligned to the right side of the icon.  

Is there something that I missed? Or can you please give me additional steps to reproduce this bug?
You need to set intl.uidirection to 1 to trigger RTL mode, with that and before this patch the search icon will be as in the screenshot
Thank you, Dale, for the information. It was really helpful.

I managed to reproduce the bug using Nightly 58 from 2017-10-09 on Windows 10x64, Mac OS X 10.11 and Ubuntu 16.04x64.
I retested everything using beta 57.0b8 on the same platforms and the bug is not reproducing anymore.
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.