JS configure doesn't respect --with-visual-studio-version

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: dmajor, Assigned: dmajor)

Tracking

unspecified
mozilla58

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment)

With both VS2015 and VS2017 installed, and --with-visual-studio-version in my mozconfig:

> checking for link... 'C:/PROGRA~2/MICROS~1.0/VC/bin/amd64/link.exe'
> js\src> checking for link... 'C:/PROGRA~2/MICROS~2/2017/COMMUN~1/VC/Tools/MSVC/1411~1.255/bin/HostX64/x64/link.exe'
Assignee: nobody → dmajor
Attachment #8916738 - Flags: review?(ted)
Attachment #8916738 - Flags: review?(ted) → review+
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/244f2649c736
Make --with-visual-studio-version a js_option. r=ted
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/244f2649c736
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.