Closed Bug 1407017 Opened 6 years ago Closed 6 years ago

JS configure doesn't respect --with-visual-studio-version

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox58 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla58
Tracking Flags:
Tracking Status
firefox58 --- fixed

People

(Reporter: away, Assigned: away)

Details

Attachments

(1 file)

Make --with-visual-studio-version a js_option
1.47 KB, patch
ted
: review+
Details | Diff | Splinter Review 
With both VS2015 and VS2017 installed, and --with-visual-studio-version in my mozconfig:

> checking for link... 'C:/PROGRA~2/MICROS~1.0/VC/bin/amd64/link.exe'
> js\src> checking for link... 'C:/PROGRA~2/MICROS~2/2017/COMMUN~1/VC/Tools/MSVC/1411~1.255/bin/HostX64/x64/link.exe'
Assignee: nobody → dmajor

        Attachment #8916738 -
        Flags: review?(ted)

        Attachment #8916738 -
        Flags: review?(ted) → review+

    
    

    
  
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/244f2649c736
Make --with-visual-studio-version a js_option. r=ted
Keywords: checkin-needed

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/244f2649c736
Status: NEW → RESOLVED
Closed: 6 years ago

          status-firefox58:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla58

    
  
Product: Core → Firefox Build System

          You need to log in
          before you can comment on or make changes to this bug.