Closed Bug 1407029 Opened 2 years ago Closed 2 years ago

Support building with SDK Tools v26

Categories

(Firefox Build System :: Android Studio and Gradle Integration, enhancement, major)

All
Android
enhancement
Not set
major

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: JanH, Assigned: JanH)

Details

Attachments

(1 file)

I made the mistake of updating my SDK to v26 and ended up with a broken build because of linter-related changes.

I've got a simple patch that got me unstuck again, although I've no idea whether everything really works as it used to before.
Comment on attachment 8916760 [details]
Bug 1407029 - Accept Android lint dependencies from SDK versions 26.0.0*.

https://reviewboard.mozilla.org/r/187836/#review193246

Thanks, JanH.  snorp ran into this recently.

::: commit-message-369e6:1
(Diff revision 1)
> +Bug 1407029 - Allow building with SDK Tools v26. r?nalexander

Make this, and the bug, something like:

Bug 1407029 - Accept Android lint dependencies from SDK versions 26.0.0*. r=nalexander

::: old-configure.in:2223
(Diff revision 1)
>  dnl mobile target.
>  dnl ========================================================
>  
>  case "$MOZ_BUILD_APP" in
>  mobile/android)
> -    MOZ_ANDROID_SDK(23, 23, 23.0.3 23.0.1, 25.3.2 25.3.1)
> +    MOZ_ANDROID_SDK(23, 23, 23.0.3 23.0.1, 25.3.2 25.3.1 26.0.0-dev)

Let's look ahead -- add `26.0.0` before `26.0.0-dev`, please.
Attachment #8916760 - Flags: review?(nalexander) → review+
Comment on attachment 8916760 [details]
Bug 1407029 - Accept Android lint dependencies from SDK versions 26.0.0*.

https://reviewboard.mozilla.org/r/187836/#review193246

> Let's look ahead -- add `26.0.0` before `26.0.0-dev`, please.

Ah, I just thought that this was some weird change in the naming scheme and didn't realise that those are actually just preview versions. Makes sense, though.
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/447614924cd2
Accept Android lint dependencies from SDK versions 26.0.0*. r=nalexander
https://hg.mozilla.org/mozilla-central/rev/447614924cd2
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox for Android → Firefox Build System
Target Milestone: Firefox 58 → mozilla58
You need to log in before you can comment on or make changes to this bug.