1407063 - libstagefright unified build fixes

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

While importing libstagefright into gecko-media crate, we've needed to fix some unified build errors.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in MoofParser.cpp.

The stagefright namespace isn't used in this file and because it
wasn't previously declared in this compilation unit, a compiler error was raised.

Review commit: https://reviewboard.mozilla.org/r/187850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187850/

Comment 2

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in DecoderData.cpp.

EndianUtils.h include was missing and some function calls required
explicit mention to the mozilla namespace.

Review commit: https://reviewboard.mozilla.org/r/187852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187852/

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in SinfParser.cpp.

The Stream class is used in this compilation unit so the Stream.h header needs
to be included.

Review commit: https://reviewboard.mozilla.org/r/187854/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187854/

Comment 4

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in ESDS.cpp.

Fallible is used in this compilation unit so the corresponding header
needs to be included. The <new> header is also required for new placement
calls.

Review commit: https://reviewboard.mozilla.org/r/187856/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187856/

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in MPEG4Extractor.cpp.

Calls to fallible need to be prefixed by the mozilla namespace because
it's not declared as globally usable.

Review commit: https://reviewboard.mozilla.org/r/187858/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187858/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407063 - Fix non-unified build in SampleTable.h.

nsTArray was previously used without prior declaration. Including the nsTArray.h
header fixes this issue.

Review commit: https://reviewboard.mozilla.org/r/187860/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/187860/

Comment 7

[Jean-Yves Avenard [:jya]]

Stagefright should really be removed, and only things left really are the MetaData stuff and MoofParser/Index

Everything else should go.

Comment 8

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

(In reply to Jean-Yves Avenard [:jya] from comment #7)
> Stagefright should really be removed, and only things left really are the
> MetaData stuff and MoofParser/Index
> 
> Everything else should go.

I opened bug 1314441 moons ago for that, but obviously haven't had the time to work on it.
But I guess importing dead code is not too much of a problem, except for code size.

Comment 9

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916792 [details]
Bug 1407063 - Fix non-unified build in MoofParser.cpp.

https://reviewboard.mozilla.org/r/187850/#review192926

Comment 10

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916793 [details]
Bug 1407063 - Fix non-unified build in DecoderData.cpp.

https://reviewboard.mozilla.org/r/187852/#review192928

Comment 11

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916794 [details]
Bug 1407063 - Fix non-unified build in SinfParser.cpp.

https://reviewboard.mozilla.org/r/187854/#review192930

Comment 12

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916795 [details]
Bug 1407063 - Fix non-unified build in ESDS.cpp.

https://reviewboard.mozilla.org/r/187856/#review192934

Comment 13

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916796 [details]
Bug 1407063 - Fix non-unified build in MPEG4Extractor.cpp.

https://reviewboard.mozilla.org/r/187858/#review192936

Comment 14

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8916797 [details]
Bug 1407063 - Fix non-unified build in SampleTable.h.

https://reviewboard.mozilla.org/r/187860/#review192938

Comment 15

[Chris Pearce [:cpearce (Not reading bugmail)]]

Thanks for the review. Yes, removing code we're not using would be great.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/691a6aaf41eb
Fix non-unified build in MoofParser.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/c948974d941d
Fix non-unified build in DecoderData.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/103a0e570e30
Fix non-unified build in SinfParser.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/315142c8e038
Fix non-unified build in ESDS.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/827c8955e797
Fix non-unified build in MPEG4Extractor.cpp. r=gerald
https://hg.mozilla.org/integration/autoland/rev/b79df840493d
Fix non-unified build in SampleTable.h. r=gerald

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/691a6aaf41eb
https://hg.mozilla.org/mozilla-central/rev/c948974d941d
https://hg.mozilla.org/mozilla-central/rev/103a0e570e30
https://hg.mozilla.org/mozilla-central/rev/315142c8e038
https://hg.mozilla.org/mozilla-central/rev/827c8955e797
https://hg.mozilla.org/mozilla-central/rev/b79df840493d