Closed Bug 1407077 Opened 3 years ago Closed 3 years ago

Use photon colors for devtools highlighted icons

Categories

(DevTools :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

Details

Attachments

(2 files)

Followup to 1399886

(In reply to Victoria Wang [:victoria] from comment #19)
> Thanks for the clear screenshots, Julian! I agree with your suggestions of
> Green 60 in light theme and Green 50 in dark theme. 
> 
> Two other changes I want to make, which should probably made in separate
> bugs/discussions: remove background color of those tabs unless there is some
> reasoning I don't understand there. Also, maybe some kind of "stopped" icon
> appearing would be make the Debugger indicator more clear.
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8916820 [details]
Bug 1407077 - use photon colors for highlighted devtools toolbar icons;

https://reviewboard.mozilla.org/r/187890/#review193120
Attachment #8916820 - Flags: review?(gl) → review+
Comment on attachment 8916821 [details]
Bug 1407077 - remove background color for highlighted devtools tabs;

https://reviewboard.mozilla.org/r/187892/#review193122
Attachment #8916821 - Flags: review?(gl) → review+
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0947fb7cdfd2
use photon colors for highlighted devtools toolbar icons;r=gl
https://hg.mozilla.org/integration/autoland/rev/0164d163b6bc
remove background color for highlighted devtools tabs;r=gl
https://hg.mozilla.org/mozilla-central/rev/0947fb7cdfd2
https://hg.mozilla.org/mozilla-central/rev/0164d163b6bc
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.