1407104 - Use "let" rather than "var" in reftest harness JS

Status: RESOLVED FIXED

(Testing :: Reftest, enhancement)

Description

[Tobias Schneider [:tobytailor]]

As suggested in point 2 of https://bugzilla.mozilla.org/show_bug.cgi?id=1299848#c68, we should prefer using "let" over "var" for better scoping & to avoid subtle bugs & leakage.

Comment 1

[Tobias Schneider [:tobytailor]]

Attachment: Replace usage of "var" with "let"

Comment 2

[Daniel Holbert [:dholbert]]

Comment on attachment 8916858 [details] [diff] [review]
Replace usage of "var" with "let"

Review of attachment 8916858 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good -- just 2 commit message nits
> Bug 1407104 - Follow up 1299848 - Use "let" rather than "var"

(1) Please remove the "Follow up 1299848" chunk. (If you want to include that info, let's put it in a second line (as bonus information outside of the main commit message), and s/1299848/bug 1299848/ so it's clearer what that number represents.)

(2) Please add "in reftest harness JS" at the end of the commit message, so it's clearer what area of code you're touching.

So this should end up looking like:
  Bug 1407104 - Use "let" rather than "var" in reftest harness JS. r=dholbert

(with an optional additional line to mention the other bug, if you want)

Comment 3

[Tobias Schneider [:tobytailor]]

Attachment: Use "let" rather than "var" in reftest harness JS

Better commit message.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f7ed7b8415b
Use "let" rather than "var" in reftest harness JS. r=dholbert

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5f7ed7b8415b