Use "let" rather than "var" in reftest harness JS

RESOLVED FIXED in Firefox 58

Status

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: tschneider, Assigned: tschneider)

Tracking

Trunk
mozilla58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

As suggested in point 2 of https://bugzilla.mozilla.org/show_bug.cgi?id=1299848#c68, we should prefer using "let" over "var" for better scoping & to avoid subtle bugs & leakage.
Attachment #8916858 - Flags: review?(dholbert)
Comment on attachment 8916858 [details] [diff] [review]
Replace usage of "var" with "let"

Review of attachment 8916858 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks! Looks good -- just 2 commit message nits
> Bug 1407104 - Follow up 1299848 - Use "let" rather than "var"

(1) Please remove the "Follow up 1299848" chunk. (If you want to include that info, let's put it in a second line (as bonus information outside of the main commit message), and s/1299848/bug 1299848/ so it's clearer what that number represents.)

(2) Please add "in reftest harness JS" at the end of the commit message, so it's clearer what area of code you're touching.

So this should end up looking like:
  Bug 1407104 - Use "let" rather than "var" in reftest harness JS. r=dholbert

(with an optional additional line to mention the other bug, if you want)
Attachment #8916858 - Flags: review?(dholbert) → review+
Better commit message.
Attachment #8916858 - Attachment is obsolete: true
Pushed by tschneider@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f7ed7b8415b
Use "let" rather than "var" in reftest harness JS. r=dholbert
Assignee: nobody → tschneider
Component: Printing: Output → Reftest
Product: Core → Testing
Summary: Follow up 1299848 - Use "let" rather than "var" → Use "let" rather than "var" in reftest harness JS
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/5f7ed7b8415b
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.