Closed Bug 1407123 Opened 2 years ago Closed 2 years ago

Intermittent toolkit/components/url-classifier/tests/unit/test_listmanager.js | xpcshell return code: 0

Categories

(Toolkit :: Safe Browsing, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- fixed
firefox63 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: dimi)

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file)

https://wiki.mozilla.org/Bugmasters#Intermittent_Test_Failure_Cleanup
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Assignee: nobody → dlee
Status: REOPENED → ASSIGNED
Priority: P5 → P2
The test_partialUpdateV4() test case doesn't wait for the update task
to be finished. It checks the status in the HTTP server side and then calls
run_next_test(). However, when XPCShell test is done, it will trigger
the shutdown process and hence interrupt the ongoing update task.

This cause the xpcshell test receives an error since the update is
interrupted and returns an error like NS_ERROR_UC_UPDATE_SHUTDOWNING.

This patch also fixes a javascript error that we didn't stop the httpd
server when cleanup.
Comment on attachment 8994860 [details]
Bug 1407123 - Wait for the update task to be finished before running next test case. r?francois

François Marier [:francois] has approved the revision.

https://phabricator.services.mozilla.com/D2360
Attachment #8994860 - Flags: review+
Pushed by dlee@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/156f576151eb
Wait for the update task to be finished before running next test case. r=francois
https://hg.mozilla.org/mozilla-central/rev/156f576151eb
Status: ASSIGNED → RESOLVED
Closed: 2 years ago2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
https://hg.mozilla.org/releases/mozilla-beta/rev/75b021eb6f7f
Flags: in-testsuite+
Whiteboard: [stockwell disable-recommended] → [stockwell fixed]
You need to log in before you can comment on or make changes to this bug.