Closed Bug 1407164 Opened 7 years ago Closed 7 years ago

JavaScript strict warning: Bookmarks.jsm, line 1529: reference to undefined property "source" when running xpcshell-tests

Categories

(Toolkit :: Places, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: standard8, Assigned: standard8)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

I'm seeing this when running toolkit/components/places/tests/unit/test_bookmarks_json.js (although I first noticed it working on the html bookmark import):

PROCESS_OUTPUT: Thread-1 (pid:67759) "JavaScript strict warning: resource://gre/modules/Bookmarks.jsm, line 1529: ReferenceError: reference to undefined property "source""
Thread-1 INFO "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "source"" {file: "resource://gre/modules/Bookmarks.jsm" line: 1529}]"

It also happens when importing bookmarks with javascript strict mode turned on.
Status: NEW → ASSIGNED
Priority: -- → P2
Whiteboard: [fxsearch]
Comment on attachment 8916903 [details]
Bug 1407164 - Fix strict warnings in Bookmarks.jsm relating to undefined property source - don't delete item properties too soon.

https://reviewboard.mozilla.org/r/187944/#review193070
Attachment #8916903 - Flags: review?(mak77) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d77fd67f3722
Fix strict warnings in Bookmarks.jsm relating to undefined property source - don't delete item properties too soon. r=mak
https://hg.mozilla.org/mozilla-central/rev/d77fd67f3722
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.