Closed Bug 1407178 Opened 3 years ago Closed 2 years ago
_webconsole _certificate _messages .js in the new console
59 bytes, text/x-review-board-request
No description provided.
Assignee: nobody → nchevobbe
Status: NEW → ASSIGNED
Comment on attachment 8916914 [details] Bug 1407178 - Enable browser_webconsole_certificate_messages.js in the new console; . https://reviewboard.mozilla.org/r/187948/#review193554 Looks good! R+ (green on Win10) Honza
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/2f3dd84d4d22 Enable browser_webconsole_certificate_messages.js in the new console; r=Honza.
Backed out for frequently failing enabled test: https://hg.mozilla.org/integration/autoland/rev/a97a53dfbaeb7373969c73a39f6e4c004577aa23 Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2f3dd84d4d228a6a52f47164eabd1298ed26ebe9&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=136223822&repo=autoland > devtools/client/webconsole/new-console-output/test/mochitest/browser_webconsole_certificate_messages.js | There is a warning message for SHA-1
I can reproduce. The thing is, the original test we copied fails to for `./mach test devtools/client/webconsole/test/browser_webconsole_certificate_messages.js --verify` I think this has to do with how we don't want to show security messages again if you reload the page. Should I find a way to make the test green when using test-verify, or is there some way to bypass test-verify since it hits a feature ?
Flags: needinfo?(nchevobbe) → needinfo?(aryx.bugmail)
Geoff, can you answer the questions in comment 6, please? From the sheriffing point of view, having the test running in test-verify without special behavior would be the best. Is it possible to run a cleanup function after the test like clearing the cache so the issue goes away?
Flags: needinfo?(aryx.bugmail) → needinfo?(gbrown)
I can't think of a way to bypass test-verify (other than disabling the test, obviously not what you want here!). It would be best to find a way to make the test green with test-verify, otherwise it will fail TV the next time the test is modified, and we'll have another conversation like this. :) It looks like your test is failing test-verify on the first step, which runs the test with --repeat. That will cause trouble for tests that rely on an initial state that is not restored at the end of the test: Your security message hypothesis sounds right. It is tempting to argue, "just don't run the test with --repeat", but it leaves your test vulnerable to the possibility that someone will add a new test, run earlier in the manifest, that changes that state and causes your test to fail. Better to "fix" your test. That said, I think the argument "This test failed verify before, and I think I am improving the test" is a reasonable argument for proceeding with landing with test-verify failing, if you really want to.
Priority: -- → P3
Comment on attachment 8916914 [details] Bug 1407178 - Enable browser_webconsole_certificate_messages.js in the new console; . Clearing the review flag since things changed a bit since the backout
Attachment #8916914 - Flags: review+ → review?(odvarko)
Comment on attachment 8916914 [details] Bug 1407178 - Enable browser_webconsole_certificate_messages.js in the new console; . https://reviewboard.mozilla.org/r/187948/#review203726 Looks reasonable Honza
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/4619d49c91f5 Enable browser_webconsole_certificate_messages.js in the new console; r=Honza.
Duplicate of this bug: 1243990
You need to log in before you can comment on or make changes to this bug.