1407180 - [translate] unchanged filter should only check active translations

Status: RESOLVED FIXED

(Webtools Graveyard :: Pontoon, defect, P3)

Description

[[DEACTIVATED] Adrian Gaudebert]

At the moment, the "unchanged" filter on the translate page matches an entity if it has a translation that is equal to any of its plural forms, regardless of whether that translation is active or not.

It means that filter returns results for which the active translation is not unchanged, which is not what it should do.

Expected behavior:
Only entities for which the active translations are unchanged are returned.

Example: https://pontoon.mozilla.org/fr/pontoon-intro/messages.properties/?extra=unchanged

Comment 3

[Raivis Dejus]

Can we somehow increase priority of this? For Latgalian we have quite a list of strings that need checking and re-translation and this issue is slowing the work significantly. Fix does not seem too hard or time consuming once someone takes a look :)

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1032

Comment 5

[Matjaz Horvat [:mathjazz]]

Raivis, given that bug 1481175 got fixed, I wonder if you're still interested in fixing this bug. It should be much simpler now.

Comment 6

[Raivis Dejus]

Thanks for heads up. 
Will check and fix this bug :)

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/pontoon/pull/1077

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/pontoon

https://github.com/mozilla/pontoon/commit/a22138e47383a3b7c8bc3d48c84fa2671c67f1d4
Fix bug 1407180: unchanged filter only on active translations (#1077)

Unchanged filter will check only active translations to avoid false
positives that have been historically translated with unchanged string,
but have been changed (fixed) since.