Remove obsolete BrowserStartup and BrowserShutdown functions

RESOLVED FIXED in Firefox 58

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: dao, Assigned: nikshepsvn, Mentored)

Tracking

(Blocks 1 bug, {good-first-bug})

Trunk
Firefox 58
Points:
---

Firefox Tracking Flags

(firefox58 fixed)

Details

(Whiteboard: [lang=js])

Attachments

(1 attachment, 1 obsolete attachment)

Comment 1

2 years ago
Hi,
I'm new to open-source projects and would like to take this up. Please guide/mentor me through this.
(Reporter)

Comment 2

2 years ago
(In reply to Shobhit Chittora from comment #1)
> Hi,
> I'm new to open-source projects and would like to take this up. Please
> guide/mentor me through this.

Hi! Have you pulled / downloaded the source code? Have you built Firefox yet?
Flags: needinfo?(chittorashobhit)

Comment 3

2 years ago
Hey! I'm downloading the dependencies and will try to build now. Thanks for your patience.
Flags: needinfo?(chittorashobhit)
(Assignee)

Comment 4

2 years ago
Hey Dao -- I just went through and fixed the issue. Please let me know if my changes were sufficient :)
Flags: needinfo?(dao+bmo)
(Reporter)

Comment 5

2 years ago
(In reply to nikshepsvn from comment #4)
> Created attachment 8917154 [details] [diff] [review]
> removed_obsolete_BrowserStartup_and_BrowserShutdown_functions
> 
> Hey Dao -- I just went through and fixed the issue. Please let me know if my
> changes were sufficient :)

This looks like an export of mozilla-central tip rather than your patch. Have you committed your changes before trying to export them?
Flags: needinfo?(dao+bmo) → needinfo?(nikshepsvn)
(Reporter)

Updated

2 years ago
Assignee: nobody → nikshepsvn
(Assignee)

Comment 6

2 years ago
oh my bad -- I forgot to commit them! Will commit and upload a patch soon -- sorry!
Flags: needinfo?(nikshepsvn)
(Assignee)

Comment 7

2 years ago
fixed patch file
Attachment #8917154 - Attachment is obsolete: true
Flags: needinfo?(dao+bmo)
Attachment #8917441 - Flags: review?(dao+bmo)
(Reporter)

Comment 8

2 years ago
Comment on attachment 8917441 [details] [diff] [review]
removedObseleteBrowserStartupAndShutdownfunctions.patch

Looks good, thanks!
Flags: needinfo?(dao+bmo)
Attachment #8917441 - Flags: review?(dao+bmo) → review+

Comment 9

2 years ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/893e45de11ab
Remove obsolete BrowserStartup and BrowserShutdown functions. r=dao
(Assignee)

Comment 10

2 years ago
woot, thank you!

Comment 11

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/893e45de11ab
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
(Reporter)

Updated

2 years ago
Blocks: 1387013
No longer depends on: 1387013
You need to log in before you can comment on or make changes to this bug.