1407234 - Invalid client id type in preferences with a new profile

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Adrian Florinescu [:aflorinescu]]

[Environment:]
56.0   20170926190823
57.0b6 20171005195903
58.0a1 20171009100134

Ubuntu 16.04x64, Windows 10x64, MacOsX10.12


[Steps:]
1. Open Firefox 56 with a new profile. (this happens first time startup on new profile only)
2. Open browser console.
3(optional). I've also enabled telemetry trace log and shield log level 0 before first run.


[Actual Result:]
https://pastebin.mozilla.org/9069627

line 9. 1507633826442   Toolkit.Telemetry  ERROR     ClientID::getCachedClientID - invalid client id type in preferences, resetting  Log.jsm:752


After restart, I don't see this error anymore.

[Note1:]
Not sure what these errors mean, but I would like to make sure there are not connected or dependent of the bug 1406532, before moving this issue to a better component.

[Note2:]
Is this a dupe after bug 1218746 or rather a regression?

Comment 1

[Alessio Placitelli [:Dexter]]

(In reply to Adrian Florinescu [:AdrianSV] from comment #0)
> [Note2:]
> Is this a dupe after bug 1218746 or rather a regression?

Thanks Adrian! This looks like a regression, possibly from 1357517.

Just to make sure the SHIELD experiment isn't interfering, would you mind checking if this is happening on a new profile without any shield experiment (it should!)?

Comment 2

[Adrian Florinescu [:aflorinescu]]

I've created a new profile, setting the prefs.js with user_pref("extensions.shield-recipe-client.enabled",false); on the first run startup comment 0 reproduced, so I guess it's safe to assume that no Shield experiment got in the way.

Comment 3

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1407234 - Don't show getCachedClientID error on new profiles.

This patch changes ClientID.jsm to only check for the pref validity if
the cached client id pref was set.

Review commit: https://reviewboard.mozilla.org/r/188362/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188362/

Comment 4

[Chris H-C :chutten]

Comment on attachment 8917357 [details]
Bug 1407234 - Don't show getCachedClientID error on new profiles.

https://reviewboard.mozilla.org/r/188362/#review193616

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4b4228043dd8
Don't show getCachedClientID error on new profiles. r=chutten

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/4b4228043dd8

Comment 7

[Julien Cristau [:jcristau]]

Calling this wontfix for 57, please reset back to affected and request uplift if you disagree.