1407248 - SystemGroup.cpp uses StaticPtr without including it

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

Something in bug 1363877 changed SystemGroup.cpp in such a way that I get this compile error in gecko-media crate:

cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp: In static member function ‘static bool SystemGroupImpl::Initialized()’:
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp:26:39: error: no match for ‘operator!’ (operand type is ‘mozilla::StaticRefPtr<SystemGroupImpl>’)
cargo:warning=   static bool Initialized() { return !!sSingleton; }
cargo:warning=                                       ^~~~~~~~~~~
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp:26:39: note: candidate: operator!(bool) <built-in>
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp:26:39: note:   no known conversion for argument 1 from ‘mozilla::StaticRefPtr<SystemGroupImpl>’ to ‘bool’
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp: At global scope:
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp:33:48: error: aggregate ‘mozilla::StaticRefPtr<SystemGroupImpl> SystemGroupImpl::sSingleton’ has incomplete type and cannot be defined
cargo:warning= StaticRefPtr<SystemGroupImpl> SystemGroupImpl::sSingleton;
cargo:warning=                                                ^~~~~~~~~~
cargo:warning=In file included from gecko/include/mozilla/AlreadyAddRefed.h:12:0,
cargo:warning=                 from gecko/include/mozilla/SchedulerGroup.h:10,
cargo:warning=                 from gecko/include/mozilla/SystemGroup.h:11,
cargo:warning=                 from gecko/src/xpcom/threads/SystemGroup.cpp:7:
cargo:warning=gecko/src/xpcom/threads/SystemGroup.cpp: In static member function ‘static void SystemGroupImpl::InitStatic()’:
cargo:warning=gecko/glue/include/mozilla/Assertions.h:417:71: error: template argument 1 is invalid
cargo:warning=      static_assert(mozilla::detail::AssertionConditionType<decltype(x)>::isValid, \

The compiler doesn't know how to convert a StaticPtr<SystemGroupImpl> to a bool using operator!.

Including mozilla/StaticPtr.h fixes it.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1407248 - Include StaticPtr.h in SystemGroup.cpp.

We were using a StaticRefPtr without it being fully defined for
SystemGroupImpl::sSingleton, resulting in a non-unified build failure.

Review commit: https://reviewboard.mozilla.org/r/188028/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188028/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8916992 [details]
Bug 1407248 - Include StaticPtr.h in SystemGroup.cpp.

https://reviewboard.mozilla.org/r/188028/#review193368

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/074c0e2a308b
Include StaticPtr.h in SystemGroup.cpp. r=billm

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/074c0e2a308b