1407254 - Back and Forward buttons' border disappears when enabling WebRender in Firefox Nightly with Linux 64bits

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Nicholas Weaver]

Attachment: bug-firefox-nightly-with-webrender-enabled.png

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:52.0) Gecko/20100101 Firefox/52.0
Build ID: 20100101

Steps to reproduce:

1. Enable WebRender following the steps here: https://mozillagfx.wordpress.com/2017/09/25/webrender-newsletter-5/ (gfx.webrender.layers-free is no longer needed)
2. Restart the browser.


Actual results:

Back and Forward buttons disappear (see attachment).


Expected results:

Back and Forward buttons shouldn't disappear.

Comment 1

[Darkspirit]

Thanks for reporting!
I can't reproduce with Nightly 58 x64 20171010100200 de_DE @ Debian Testing (KDE, Radeon RX480).
Which OS, OS version and graphics card do you use? You can see your real build id on about:support. Is this a fresh profile only with those mentioned prefs or did you change some more (or switched the theme, have addons)?

Comment 2

[Nicholas Weaver]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #1)
> Thanks for reporting!
> I can't reproduce with Nightly 58 x64 20171010100200 de_DE @ Debian Testing
> (KDE, Radeon RX480).
> Which OS, OS version and graphics card do you use? You can see your real
> build id on about:support. Is this a fresh profile only with those mentioned
> prefs or did you change some more (or switched the theme, have addons)?
Ubuntu 17.04 64 bits, build ID: 20171010100200, device ID: Gallium 0.4 on AMD RV710 (DRM 2.49.0 / 4.10.0-35-generic, LLVM 4.0.0).

I changed some privacy configs (enabling privacy.resistFingerprinting for example). I didn't switch the theme, and have two WebExtensions (UBlock, Decentraleyes)

Comment 3

[Nicholas Weaver]

Here's the output when running ./firefox-bin --debug https://gist.githubusercontent.com/anonymous/4767a06d890a149a8367582f0334d654/raw/c5c2e52ea3b72d11ddb4abf948dee23044542c11/debug-firefox-nightly.txt

Comment 4

[Darkspirit]

(Nicholas Weaver from comment #3)
> Here's the output when running ./firefox-bin --debug

> [...]
> WebRender - OpenGL version new 3.3 (Core Profile) Mesa 17.0.7
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=0) -1
> EE [...]gallium/drivers/r600/r600_shader.c:3663 r600_shader_from_tgsi - GPR limit exceeded - shader requires 239 registers
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=0) -12
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=0) -1
> EE [...]gallium/drivers/r600/r600_shader.c:3663 r600_shader_from_tgsi - GPR limit exceeded - shader requires 239 registers
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=0) -12
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=1) -1
> EE [...]gallium/drivers/r600/r600_shader.c:183 r600_pipe_shader_create - translation from TGSI failed !
> EE [...]gallium/drivers/r600/r600_state_common.c:799 r600_shader_select - Failed to build shader variant (type=0) -1
> EE [...]gallium/drivers/r600/r600_shader.c:3663 r600_shader_from_tgsi - GPR limit exceeded - shader requires 239 registers
> [... repeats in a loop  ...]

Comment 5

[Keith Hizal]

I can't reproduce this either on build 20171010100200.
I'm using openSUSE Tumbleweed and my graphics card is AMD Radeon (TM) RX 460 Graphics (AMD POLARIS11 / DRM 3.18.0 / 4.13.4-1-default, LLVM 4.0.1)

Comment 7

[Nicholas Weaver]

Not sure how useful this may be to you, but this bug happens only after enabling layers.acceleration.force-enabled

Comment 8

[Nicholas Weaver]

(Precision to the above: Only when layers.acceleration.force-enabled is disabled while gfx.webrender.enabled, gfx.webrendest.enabled, gfx.webrender.blob-images are all enabled)

Comment 9

[Darkspirit]

(In reply to Nicholas Weaver from comment #8)
> (Precision to the above: Only when layers.acceleration.force-enabled is disabled while gfx.webrender.enabled

Without layers.acceleration.force-enabled WebRender won't work on Linux. You can't (shouldn't) see "Compositing: WebRender" on about:support then.

Windows has a similar problem with the back button (bug 1409302), and border-radius itself has some cosmetic issues (bug 1404158). Only the WebRender developers might know if your debug log is directly related to your back/forward button issue (but why not?^^).

Comment 10

[Darkspirit]

(In reply to Nicholas Weaver from comment #0)

Can you still reproduce this bug or do you think it got fixed?
(Prefs: layers.acceleration.force-enabled;true + gfx.webrender.enabled;true + gfx.webrender.blob-images;true)

Comment 11

[Nicholas Weaver]

(In reply to Jan Andre Ikenmeyer [:darkspirit] from comment #10)
> (In reply to Nicholas Weaver from comment #0)
> 
> Can you still reproduce this bug or do you think it got fixed?
> (Prefs: layers.acceleration.force-enabled;true + gfx.webrender.enabled;true
> + gfx.webrender.blob-images;true)

(Build ID: 20171122220056)

The buttons do appear now, but, their border doesn't get rendered (see the attachment below).

Here's the output when running ./firefox-bin --debug https://gist.githubusercontent.com/anonymous/d7c4634bd02790cd32b30fec8e1b3822/raw/6b632bfdef81e80a8a60239d7868947bce8d4d96/debug.txt

Should I change the name of this ticket or close this one and open a new one?

Comment 12

[Nicholas Weaver]

Attachment: nightly-webrender-bug.png

Comment 13

[Nicholas Weaver]

I can confirm that this issue is fixed when installing the latest drivers: https://launchpad.net/~oibaf/+archive/ubuntu/graphics-drivers

The relevant WebRender bug: https://github.com/servo/webrender/issues/1601