1407344 - Missing placeholder in Focus Android: preference_default_browser2

Status: RESOLVED FIXED

(Mozilla Localizations :: lt / Lithuanian, enhancement)

Description

[Chenxia Liu [:liuche]]

https://github.com/mozilla-l10n/focus-android-l10n/blob/master/locales/lt/app.po#L273

The placeholder is missing from the string:

msgctxt "preference_default_browser2"
msgid "Make %1$s default browser"
msgstr "Padaryti numatytąja naršykle"

Comment 1

[Delphine Lebédel [:delphine - Use needinfo]]

Hey Paulius, could you help fix this and add the placeholder where it should be? I wouldn't know where to add it in the string :)
(https://pontoon.mozilla.org/lt/focus-for-android/app.po/?search=preference_default_browser2&string=171596)
thanks!

Comment 2

[Paulius Andriekus]

Added. Are placeholder's always mandatory though? In this case, it's inside the browser's settings, and explicitly stating the name doesn't add any new information IMO. I believe Rimas did that in a few strings in Firefox for desktop as well, before I joined.

Comment 3

[Delphine Lebédel [:delphine - Use needinfo]]

Hey - yes they are mandatory because depending on the country, Focus can also be called "Klar". Hope this makes sense

Comment 4

[Rimas Kudelis [use needinfo to ping]]

Delphine, is this a technical limitation? I tend to agree with Paulius: regardless of whether you call it Focus or Klar, this is an in-app string, so the name of the app is kinda known in advance.

Comment 5

[Delphine Lebédel [:delphine - Use needinfo]]

I think it is because the same string will be re-used in both cases - let's just double check with :liuche but I don't think there's a way to work around this at this point. Maybe she can explain better!

Comment 6

[Chenxia Liu [:liuche]]

Hi Paulius and Rimas, the missing placeholders are something that we have a script to check for while validating the strings. There are strings where the placeholders are absolutely necessary, or it's useful to check because a placeholder might be forgotten.

So this is a technical limitation, because it's not practical to pick and choose where the placeholders are "optional" for a script - when it fails, we just remove the string. Additionally, I assume that whoever wrote the strings has tried to consider where including the brand is useful (if not necessary) especially for new users, so it's best to include the placeholders.

Comment 7

[Rimas Kudelis [use needinfo to ping]]

It seems we forgot to close this after Paulius has fixed the string.