1407374 - Port the INSTALL_TARGET in extensions/spellcheck/locales/Makefile.in to moz.build

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Michael Shal [:mshal]]

This is made slightly tricky since it pulls files from LOCALE_SRCDIR, so we need to find a way to support this in moz.build and still work with l10n.

Comment 1

[(not currently active) Ted Mielczarek]

I have a patch that uses the `LOCALIZED_FILES` implementation from bug 1409721 to do this. This is what `mach build-backend --diff` shows for the patch:
https://gist.github.com/luser/ffd3210ec7d614cd9dfaf855eba9a92d

The Makefile vs. backend.mk changes show that it looks to be generating functionally the same rules. The root[-deps].mk changes are because I removed the Makefile.in, so that directory no longer gets forced into the export tier, which is a nice side benefit. The install manifest changes are because the fastermake backend treats `LOCALIZED_FILES` the same as `FINAL_TARGET_FILES`, which should be fine for the time being. It has the other nice side effect that that means `mach build faster` will work for these localized files.

Comment 2

[(not currently active) Ted Mielczarek]

Attachment: bug 1407374 - move hunspell dictionary copying to LOCALIZED_FILES in moz.build.

Review commit: https://reviewboard.mozilla.org/r/199212/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/199212/

Comment 3

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=139a1f768f443b4de4a8ff4b86285d3228589e14

Comment 4

[(not currently active) Ted Mielczarek]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6843fdf106c0d8b2fd370c677e4579e5684a54a2

Comment 5

[Nick Alexander :nalexander [he/him]]

Comment on attachment 8927991 [details]
bug 1407374 - move hunspell dictionary copying to LOCALIZED_FILES in moz.build.

https://reviewboard.mozilla.org/r/199212/#review205006

If the prerequisites get hammered out, this will be fine.

::: extensions/spellcheck/locales/moz.build:7
(Diff revision 1)
>  # vim: set filetype=python:
>  # This Source Code Form is subject to the terms of the Mozilla Public
>  # License, v. 2.0. If a copy of the MPL was not distributed with this
>  # file, You can obtain one at http://mozilla.org/MPL/2.0/.
>  
> +LOCALIZED_FILES.dictionaries += [

Is this that one weird consumer?  It would be nicer to bake the AB_CD into the .aff and .dic file names, but I'll take this.

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 8927991 [details]
bug 1407374 - move hunspell dictionary copying to LOCALIZED_FILES in moz.build.

https://reviewboard.mozilla.org/r/199212/#review205006

> Is this that one weird consumer?  It would be nicer to bake the AB_CD into the .aff and .dic file names, but I'll take this.

Yeah, it's the only thing using wildcards for localized content. Additionally, not every locale has hunspell dictionaries, so we really do need a special case to make it work.

Comment 7

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9110808927225f45a7667f5048e6b2dfd2f2242
bug 1407374 - move hunspell dictionary copying to LOCALIZED_FILES in moz.build. r=nalexander

Comment 8

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/53047a13f6ea
Backed out changeset d91108089272

Comment 9

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out because bug 1409721 had to be backed out and this bug depended on it:

https://hg.mozilla.org/integration/mozilla-inbound/rev/53047a13f6ea05e3c325b9fd94a18da0dbf80c9f

Comment 10

[(not currently active) Ted Mielczarek]

Per bug 1409721 comment 53, I think this was the actual source of the bustage. I'll do a try push with just the commits from the other bug (including artifact builds) and if that works I'll re-land just those until I fix this.

Comment 11

[(not currently active) Ted Mielczarek]

The fix for the bustage is in bug 1419055, it was a bug in the FasterMake backend. I verified that pushing rest of the patches from bug 1409721 to try doesn't break artifact builds, so I'll re-land those until I get review on that fix.

Comment 12

[(not currently active) Ted Mielczarek]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0cfaf6902748f13a602ec69c5cd6f56b7713a4e5
bug 1407374 - move hunspell dictionary copying to LOCALIZED_FILES in moz.build. r=nalexander

Comment 13

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/0cfaf6902748