Closed Bug 1407413 Opened 8 years ago Closed 7 years ago

Use GENERATED_FILES for symverscript in js/src/build

Categories

(Firefox Build System :: General, enhancement)

Product:
Firefox Build System
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1478499

People

(Reporter: ted, Unassigned)

References

(Blocks 1 open bug)

Details

js/src/build/Makefile.in has some custom rules for generating symverscript and adding it to LDFLAGS: https://hg.mozilla.org/mozilla-central/file/77a4c52e9987d2359969d7c478183b438b464744/js/src/build/Makefile.in#l7 we already support LD_VERSION_SCRIPT in moz.build: https://dxr.mozilla.org/mozilla-central/rev/2ed5e7fbf39e949693d8a7455d6313b14a7aeaf6/python/mozbuild/mozbuild/frontend/context.py#1410 and we could do the generation using GENERATED_FILES. We might need to change LD_VERSION_SCRIPT to be a Path instead of a string, but it's not actually used in any moz.build files currently so that shouldn't be an issue.
Product: Core → Firefox Build System
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.