Closed Bug 1407426 Opened 5 years ago Closed 5 years ago

Add a smoke test for the debugger in the browser content toolbox

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox58 fixed)

RESOLVED FIXED
Firefox 58
Tracking Status
firefox58 --- fixed

People

(Reporter: jdescottes, Assigned: jdescottes)

References

Details

Attachments

(2 files)

Initially wanted to land this in the debugger.html project, but this requires first a fix in m-c, so at least some parts of it should land here.
See Also: → 1405140
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Comment on attachment 8917157 [details]
Bug 1407426 - return the toolbox created when opening BrowserContentToolbox;

https://reviewboard.mozilla.org/r/188174/#review193332
Attachment #8917157 - Flags: review?(jlaster) → review+
Comment on attachment 8917158 [details]
Bug 1407426 - add smoke test for debugger in browser content toolbox;

https://reviewboard.mozilla.org/r/188176/#review193334

w/ a green try run.
Attachment #8917158 - Flags: review?(jlaster) → review+
Comment on attachment 8917157 [details]
Bug 1407426 - return the toolbox created when opening BrowserContentToolbox;

https://reviewboard.mozilla.org/r/188174/#review193336

(forwarding r+, just made an eslint fix)
Attachment #8917157 - Flags: review+
Depends on: 1405140
Depends on: 1407840
No longer depends on: 1405140
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4c5add176917
return the toolbox created when opening BrowserContentToolbox;r=jlast
https://hg.mozilla.org/integration/autoland/rev/6558a0eae222
add smoke test for debugger in browser content toolbox;r=jlast
Backed out for failing devtools/client/debugger/new/test/mochitest/browser_dbg-browser-content-toolbox.js on Windows 7 debug without e10s:

https://hg.mozilla.org/integration/autoland/rev/c054502bd2594182b5d75d1079e8af48401ab273
https://hg.mozilla.org/integration/autoland/rev/9a120a430469f5dabd15ceb9c86719514cd57dc9

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=985aaff8c657cebe9bed39a1f159859a779be9bd&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=137208025&repo=autoland

11:03:44     INFO -  24 INFO Entering test bound
11:03:44     INFO -  25 INFO Open a tab pointing to doc-scripts.html
11:03:44     INFO -  26 INFO Adding a new tab with URL: http://example.com/browser/devtools/client/debugger/new/test/mochitest/examples/doc-scripts.html
11:03:44     INFO -  Buffered messages logged at 10:48:56
11:03:44     INFO -  27 INFO Tab added and finished loading
11:03:44     INFO -  28 INFO Open the Browser Content Toolbox
11:03:44     INFO -  Buffered messages logged at 10:54:14
11:03:44     INFO -  29 INFO Console message: [JavaScript Error: "1508151254433	Browser.Experiments.Experiments	ERROR	Experiments #0::httpGetRequest::onLoad() - Request to http://127.0.0.1:8888/experiments-dummy/manifest returned status 404" {file: "resource://gre/modules/Log.jsm" line: 752}]
11:03:44     INFO -  App_append@resource://gre/modules/Log.jsm:752:9
11:03:44     INFO -  log@resource://gre/modules/Log.jsm:390:7
11:03:44     INFO -  getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:505:44
11:03:44     INFO -  Experiments.Experiments/this._log.log@resource:///modules/experiments/Experiments.jsm:328:5
11:03:44     INFO -  error@resource://gre/modules/Log.jsm:398:5
11:03:44     INFO -  _httpGetRequest/</xhr.onload@resource:///modules/experiments/Experiments.jsm:973:11
11:03:44     INFO -  openModalWindow@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:363:5
11:03:44     INFO -  openPrompt@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:573:9
11:03:44     INFO -  alert@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:622:9
11:03:44     INFO -  alert@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:59:9
11:03:44     INFO -  openContentProcessToolbox@resource://devtools/shared/base-loader.js -> resource://devtools/client/framework/devtools-browser.js:395:5
11:03:44     INFO -  @chrome://mochitests/content/browser/devtools/client/debugger/new/test/mochitest/browser_dbg-browser-content-toolbox.js:43:23
11:03:44     INFO -  Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:807:21
11:03:44     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:331:42
11:03:44     INFO -  TaskImpl@resource://gre/modules/Task.jsm:280:3
11:03:44     INFO -  asyncFunction@resource://gre/modules/Task.jsm:252:14
11:03:44     INFO -  Task_spawn@resource://gre/modules/Task.jsm:166:12
11:03:44     INFO -  Tester_execTest@chrome://mochikit/content/browser-test.js:798:9
11:03:44     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
11:03:44     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
11:03:44     INFO -  30 INFO Console message: [JavaScript Error: "1508151254434	Browser.Experiments.Experiments	ERROR	Experiments #0::_loadManifest - failure to fetch/parse manifest (continuing anyway): Error: Experiments - XHR status for http://127.0.0.1:8888/experiments-dummy/manifest is 404" {file: "resource://gre/modules/Log.jsm" line: 752}]
11:03:44     INFO -  App_append@resource://gre/modules/Log.jsm:752:9
11:03:44     INFO -  log@resource://gre/modules/Log.jsm:390:7
11:03:44     INFO -  getLoggerWithMessagePrefix/proxy.log@resource://gre/modules/Log.jsm:505:44
11:03:44     INFO -  Experiments.Experiments/this._log.log@resource:///modules/experiments/Experiments.jsm:328:5
11:03:44     INFO -  error@resource://gre/modules/Log.jsm:398:5
11:03:44     INFO -  _loadManifest@resource:///modules/experiments/Experiments.jsm:845:7
11:03:44     INFO -  async*_main@resource:///modules/experiments/Experiments.jsm:815:15
11:03:44     INFO -  async*_run/this._mainTask<@resource:///modules/experiments/Experiments.jsm:782:17
11:03:44     INFO -  async*_run@resource:///modules/experiments/Experiments.jsm:780:25
11:03:44     INFO -  updateManifest@resource:///modules/experiments/Experiments.jsm:868:12
11:03:44     INFO -  notify@jar:file:///Z:/task_1508150276/build/application/firefox/browser/omni.ja!/components/ExperimentsService.js:51:7
11:03:44     INFO -  TM_notify/<@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsUpdateTimerManager.js:217:11
11:03:44     INFO -  TM_notify@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsUpdateTimerManager.js:262:7
11:03:44     INFO -  openModalWindow@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:363:5
11:03:44     INFO -  openPrompt@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:573:9
11:03:44     INFO -  alert@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:622:9
11:03:44     INFO -  alert@jar:file:///Z:/task_1508150276/build/application/firefox/omni.ja!/components/nsPrompter.js:59:9
11:03:44     INFO -  openContentProcessToolbox@resource://devtools/shared/base-loader.js -> resource://devtools/client/framework/devtools-browser.js:395:5
11:03:44     INFO -  @chrome://mochitests/content/browser/devtools/client/debugger/new/test/mochitest/browser_dbg-browser-content-toolbox.js:43:23
11:03:44     INFO -  Async*Tester_execTest/<@chrome://mochikit/content/browser-test.js:807:21
11:03:44     INFO -  TaskImpl_run@resource://gre/modules/Task.jsm:331:42
11:03:44     INFO -  TaskImpl@resource://gre/modules/Task.jsm:280:3
11:03:44     INFO -  asyncFunction@resource://gre/modules/Task.jsm:252:14
11:03:44     INFO -  Task_spawn@resource://gre/modules/Task.jsm:166:12
11:03:44     INFO -  Tester_execTest@chrome://mochikit/content/browser-test.js:798:9
11:03:44     INFO -  Tester.prototype.nextTest</<@chrome://mochikit/content/browser-test.js:697:9
11:03:44     INFO -  SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:795:59
11:03:44     INFO -  Buffered messages finished
11:03:44  WARNING -  TEST-UNEXPECTED-TIMEOUT | devtools/client/debugger/new/test/mochitest/browser_dbg-browser-content-toolbox.js | application timed out after 330 seconds with no output
11:03:44     INFO -  31 ERROR Force-terminating active process(es).
Flags: needinfo?(jdescottes)
The browser content toolbox is only available in e10s, so the test should be skip-if = !e10s
Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0f216d29ac80
return the toolbox created when opening BrowserContentToolbox;r=jlast
https://hg.mozilla.org/integration/autoland/rev/caef338370a5
add smoke test for debugger in browser content toolbox;r=jlast
https://hg.mozilla.org/mozilla-central/rev/0f216d29ac80
https://hg.mozilla.org/mozilla-central/rev/caef338370a5
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.