1407428 - Change nsIExpandedPrincipal::GetWhiteList to return a const array

Status: RESOLVED FIXED

(Core :: Security: CAPS, enhancement)

Description

[Kris Maglione [:kmag]]

As bz pointed out in bug 1407258, it's not obvious that the array returned by this getter is shared and can't be safely modified without reading very carefully. Since the getter is noscript, anyway, we should be able to return a const nsTArray reference, which has much clearer semantics (and can't be accidentally modified).

Comment 1

[Kris Maglione [:kmag]]

Attachment: Bug 1407428: Hand out a const array reference for expanded principal whiteList.

The current API makes the life time and ownership of the result array unclear
without careful reading. The result array is always owned by the principal,
and its lifetime tied to the lifetime of the principal itself. Returning a
const array reference makes this clear, and should prevent callers from
accidentally modifying the returned array.

Review commit: https://reviewboard.mozilla.org/r/188184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188184/

Comment 2

[Gabor Krizsanits (INACTIVE)]

Comment on attachment 8917167 [details]
Bug 1407428: Hand out a const array reference for expanded principal whiteList.

https://reviewboard.mozilla.org/r/188184/#review194660

Thanks for the cleanup!

Comment 3

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/237acf2879f6222bc4b076c377bf026d18a6ebef
Bug 1407428: Hand out a const array reference for expanded principal whiteList. r=krizsa

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for frequent crashes, e.g. in xpcshell's test_bug248970_cookie.js:

https://hg.mozilla.org/integration/mozilla-inbound/rev/994ea93958587c927e5daa729c9393056f655a9b

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=237acf2879f6222bc4b076c377bf026d18a6ebef&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=137110625&repo=mozilla-inbound

[task 2017-10-15T21:54:56.196Z] 21:54:56     INFO -  TEST-START | netwerk/cookie/test/unit/test_bug643051.js
[task 2017-10-15T21:54:56.582Z] 21:54:56  WARNING -  TEST-UNEXPECTED-FAIL | netwerk/cookie/test/unit/test_bug643051.js | xpcshell return code: -11
[task 2017-10-15T21:54:56.582Z] 21:54:56     INFO -  TEST-INFO took 387ms
[task 2017-10-15T21:54:56.583Z] 21:54:56     INFO -  >>>>>>>
[task 2017-10-15T21:54:56.584Z] 21:54:56     INFO -  PID 6232 | [6232, Main Thread] WARNING: Couldn't get the user appdata directory. Crash events may not be produced.: file /builds/worker/workspace/build/src/toolkit/crashreporter/nsExceptionHandler.cpp, line 2872
[task 2017-10-15T21:54:56.585Z] 21:54:56     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
[task 2017-10-15T21:54:56.586Z] 21:54:56     INFO -  PID 6232 | [6232, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004002: file /builds/worker/workspace/build/src/toolkit/components/resistfingerprinting/nsRFPService.cpp, line 182
[task 2017-10-15T21:54:56.587Z] 21:54:56     INFO -  PID 6232 | [6232, Main Thread] WARNING: NS_ENSURE_TRUE(aChannel) failed: file /builds/worker/workspace/build/src/dom/base/ThirdPartyUtil.cpp, line 186
[task 2017-10-15T21:54:56.588Z] 21:54:56     INFO -  PID 6232 | [6232, Main Thread] WARNING: NS_ENSURE_SUCCESS(rv, NS_ERROR_UNEXPECTED) failed with result 0x80004005: file /builds/worker/workspace/build/src/extensions/cookie/nsPermissionManager.cpp, line 982
[task 2017-10-15T21:54:56.588Z] 21:54:56     INFO -  PID 6232 | ExceptionHandler::GenerateDump cloned child 6247
[task 2017-10-15T21:54:56.589Z] 21:54:56     INFO -  PID 6232 | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-10-15T21:54:56.590Z] 21:54:56     INFO -  PID 6232 | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-10-15T21:54:56.590Z] 21:54:56     INFO -  <<<<<<<
[task 2017-10-15T21:54:56.591Z] 21:54:56     INFO -  mozcrash Copy/paste: /usr/local/bin/linux64-minidump_stackwalk /tmp/xpc-other-nz0CR8/3e251b44-a8d9-3c10-7a9a-a05d89c2d918.dmp /builds/worker/workspace/build/symbols
[task 2017-10-15T21:55:05.137Z] 21:55:05     INFO -  mozcrash Saved minidump as /builds/worker/workspace/build/blobber_upload_dir/3e251b44-a8d9-3c10-7a9a-a05d89c2d918.dmp
[task 2017-10-15T21:55:05.139Z] 21:55:05     INFO -  mozcrash Saved app info as /builds/worker/workspace/build/blobber_upload_dir/3e251b44-a8d9-3c10-7a9a-a05d89c2d918.extra
[task 2017-10-15T21:55:05.140Z] 21:55:05  WARNING -  PROCESS-CRASH | netwerk/cookie/test/unit/test_bug643051.js | application crashed [@ nsPermissionManager::CommonTestPermissionInternal]
[task 2017-10-15T21:55:05.143Z] 21:55:05     INFO -  Crash dump filename: /tmp/xpc-other-nz0CR8/3e251b44-a8d9-3c10-7a9a-a05d89c2d918.dmp
[task 2017-10-15T21:55:05.143Z] 21:55:05     INFO -  Operating system: Linux
[task 2017-10-15T21:55:05.144Z] 21:55:05     INFO -                    0.0.0 Linux 3.13.0-112-generic #159-Ubuntu SMP Fri Mar 3 15:26:07 UTC 2017 x86_64
[task 2017-10-15T21:55:05.145Z] 21:55:05     INFO -  CPU: x86
[task 2017-10-15T21:55:05.145Z] 21:55:05     INFO -       GenuineIntel family 6 model 62 stepping 4
[task 2017-10-15T21:55:05.146Z] 21:55:05     INFO -       2 CPUs
[task 2017-10-15T21:55:05.146Z] 21:55:05     INFO -  GPU: UNKNOWN
[task 2017-10-15T21:55:05.146Z] 21:55:05     INFO -  Crash reason:  SIGSEGV
[task 2017-10-15T21:55:05.147Z] 21:55:05     INFO -  Crash address: 0x40
[task 2017-10-15T21:55:05.148Z] 21:55:05     INFO -  Process uptime: not available
[task 2017-10-15T21:55:05.148Z] 21:55:05     INFO -  Thread 0 (crashed)
[task 2017-10-15T21:55:05.149Z] 21:55:05     INFO -   0  libxul.so!nsPermissionManager::CommonTestPermissionInternal [nsPermissionManager.cpp:237acf2879f6 : 2238 + 0x0]
[task 2017-10-15T21:55:05.149Z] 21:55:05     INFO -      eip = 0xf19c8416   esp = 0xffe0b150   ebp = 0xffe0b208   ebx = 0xf761c000
[task 2017-10-15T21:55:05.151Z] 21:55:05     INFO -      esi = 0xe96bc700   edi = 0x00000000   eax = 0xffe0b280   ecx = 0xf58a4cc0
[task 2017-10-15T21:55:05.152Z] 21:55:05     INFO -      edx = 0xf73cc634   efl = 0x00210246
[task 2017-10-15T21:55:05.154Z] 21:55:05     INFO -      Found by: given as instruction pointer in context
[task 2017-10-15T21:55:05.155Z] 21:55:05     INFO -   1  libxul.so!nsPermissionManager::TestPermission [nsPermissionManager.h:237acf2879f6 : 316 + 0x17]
[task 2017-10-15T21:55:05.157Z] 21:55:05     INFO -      eip = 0xf19c867b   esp = 0xffe0b210   ebp = 0xffe0b238   ebx = 0xf761c000
[task 2017-10-15T21:55:05.158Z] 21:55:05     INFO -      esi = 0xe96bc700   edi = 0xffe0b353
[task 2017-10-15T21:55:05.161Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.162Z] 21:55:05     INFO -   2  libxul.so!nsCookiePermission::CanSetCookie [nsCookiePermission.cpp:237acf2879f6 : 189 + 0x20]
[task 2017-10-15T21:55:05.165Z] 21:55:05     INFO -      eip = 0xf19c4640   esp = 0xffe0b240   ebp = 0xffe0b2f8   ebx = 0xf761c000
[task 2017-10-15T21:55:05.166Z] 21:55:05     INFO -      esi = 0xe96bc700   edi = 0xffe0b353
[task 2017-10-15T21:55:05.167Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.169Z] 21:55:05     INFO -   3  libxul.so!nsCookieService::SetCookieInternal [nsCookieService.cpp:237acf2879f6 : 3644 + 0x24]
[task 2017-10-15T21:55:05.170Z] 21:55:05     INFO -      eip = 0xf12facc2   esp = 0xffe0b300   ebp = 0xffe0b568   ebx = 0xf761c000
[task 2017-10-15T21:55:05.172Z] 21:55:05     INFO -      esi = 0xf0cafd5c   edi = 0x00055b9c
[task 2017-10-15T21:55:05.173Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.175Z] 21:55:05     INFO -   4  libxul.so!nsCookieService::SetCookieStringInternal [nsCookieService.cpp:237acf2879f6 : 2179 + 0x31]
[task 2017-10-15T21:55:05.176Z] 21:55:05     INFO -      eip = 0xf12fb011   esp = 0xffe0b570   ebp = 0xffe0b6c8   ebx = 0xe9606100
[task 2017-10-15T21:55:05.178Z] 21:55:05     INFO -      esi = 0xffe0b5e0   edi = 0xe9635240
[task 2017-10-15T21:55:05.179Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.181Z] 21:55:05     INFO -   5  libxul.so!nsCookieService::SetCookieStringCommon [nsCookieService.cpp:237acf2879f6 : 2107 + 0x11]
[task 2017-10-15T21:55:05.182Z] 21:55:05     INFO -      eip = 0xf12fb18c   esp = 0xffe0b6d0   ebp = 0xffe0b768   ebx = 0xf761c000
[task 2017-10-15T21:55:05.184Z] 21:55:05     INFO -      esi = 0xffe0b718   edi = 0xffe0b730
[task 2017-10-15T21:55:05.185Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.186Z] 21:55:05     INFO -   6  libxul.so!NS_InvokeByIndex + 0x30
[task 2017-10-15T21:55:05.188Z] 21:55:05     INFO -      eip = 0xf122aa32   esp = 0xffe0b770   ebp = 0xffe0b7b8   ebx = 0x00000000
[task 2017-10-15T21:55:05.189Z] 21:55:05     INFO -      esi = 0xffe0b830   edi = 0xffe0b7e4
[task 2017-10-15T21:55:05.191Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.192Z] 21:55:05     INFO -   7  libxul.so!CallMethodHelper::Call [XPCWrappedNative.cpp:237acf2879f6 : 1996 + 0x10]
[task 2017-10-15T21:55:05.194Z] 21:55:05     INFO -      eip = 0xf198002d   esp = 0xffe0b7c0   ebp = 0xffe0b808
[task 2017-10-15T21:55:05.195Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.197Z] 21:55:05     INFO -   8  libxul.so!XPCWrappedNative::CallMethod [XPCWrappedNative.cpp:237acf2879f6 : 1282 + 0x17]
[task 2017-10-15T21:55:05.198Z] 21:55:05     INFO -      eip = 0xf1983411   esp = 0xffe0b810   ebp = 0xffe0b8f8   ebx = 0xffe0b830
[task 2017-10-15T21:55:05.200Z] 21:55:05     INFO -      esi = 0xffe0b92c   edi = 0xffe0b930
[task 2017-10-15T21:55:05.201Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.203Z] 21:55:05     INFO -   9  libxul.so!XPC_WN_CallMethod [XPCWrappedNativeJSOps.cpp:237acf2879f6 : 929 + 0xa]
[task 2017-10-15T21:55:05.204Z] 21:55:05     INFO -      eip = 0xf19881f0   esp = 0xffe0b900   ebp = 0xffe0b9c8   ebx = 0xffe0b958
[task 2017-10-15T21:55:05.205Z] 21:55:05     INFO -      esi = 0xffe0b92c   edi = 0xffe0b930
[task 2017-10-15T21:55:05.207Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.208Z] 21:55:05     INFO -  10  libxul.so!js::CallJSNative [jscntxtinlines.h:237acf2879f6 : 291 + 0xe]
[task 2017-10-15T21:55:05.210Z] 21:55:05     INFO -      eip = 0xf3fe7b04   esp = 0xffe0b9d0   ebp = 0xffe0ba18   ebx = 0xffe0bcdc
[task 2017-10-15T21:55:05.211Z] 21:55:05     INFO -      esi = 0xee928800   edi = 0xe97f8180
[task 2017-10-15T21:55:05.212Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.213Z] 21:55:05     INFO -  11  libxul.so!js::InternalCallOrConstruct [Interpreter.cpp:237acf2879f6 : 473 + 0x13]
[task 2017-10-15T21:55:05.214Z] 21:55:05     INFO -      eip = 0xf3ffce03   esp = 0xffe0ba20   ebp = 0xffe0ba88   ebx = 0xffe0bcdc
[task 2017-10-15T21:55:05.215Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0xffe0ba4c
[task 2017-10-15T21:55:05.216Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.217Z] 21:55:05     INFO -  12  libxul.so!InternalCall [Interpreter.cpp:237acf2879f6 : 522 + 0x12]
[task 2017-10-15T21:55:05.218Z] 21:55:05     INFO -      eip = 0xf3ffd1d0   esp = 0xffe0ba90   ebp = 0xffe0bad8   ebx = 0xee928800
[task 2017-10-15T21:55:05.219Z] 21:55:05     INFO -      esi = 0xffe0bab8   edi = 0xe97f8188
[task 2017-10-15T21:55:05.220Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.221Z] 21:55:05     INFO -  13  libxul.so!Interpret [Interpreter.cpp:237acf2879f6 : 528 + 0x9]
[task 2017-10-15T21:55:05.222Z] 21:55:05     INFO -      eip = 0xf3ff06c6   esp = 0xffe0bae0   ebp = 0xffe0bdf8   ebx = 0xffe0bcdc
[task 2017-10-15T21:55:05.223Z] 21:55:05     INFO -      esi = 0xee928800   edi = 0xf761c000
[task 2017-10-15T21:55:05.224Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.225Z] 21:55:05     INFO -  14  libxul.so!js::RunScript [Interpreter.cpp:237acf2879f6 : 423 + 0x10]
[task 2017-10-15T21:55:05.226Z] 21:55:05     INFO -      eip = 0xf3ffca1c   esp = 0xffe0be00   ebp = 0xffe0beb8   ebx = 0xee928800
[task 2017-10-15T21:55:05.227Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0x00000000
[task 2017-10-15T21:55:05.228Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.229Z] 21:55:05     INFO -  15  libxul.so!js::InternalCallOrConstruct [Interpreter.cpp:237acf2879f6 : 495 + 0x12]
[task 2017-10-15T21:55:05.230Z] 21:55:05     INFO -      eip = 0xf3ffcec4   esp = 0xffe0bec0   ebp = 0xffe0bf28   ebx = 0xffe0c03c
[task 2017-10-15T21:55:05.231Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0xffe0beec
[task 2017-10-15T21:55:05.232Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.233Z] 21:55:05     INFO -  16  libxul.so!InternalCall [Interpreter.cpp:237acf2879f6 : 522 + 0x12]
[task 2017-10-15T21:55:05.234Z] 21:55:05     INFO -      eip = 0xf3ffd1d0   esp = 0xffe0bf30   ebp = 0xffe0bf78   ebx = 0xee928800
[task 2017-10-15T21:55:05.235Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0xffe0c288
[task 2017-10-15T21:55:05.236Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.237Z] 21:55:05     INFO -  17  libxul.so!js::jit::DoCallFallback [BaselineIC.cpp:237acf2879f6 : 2534 + 0x15]
[task 2017-10-15T21:55:05.238Z] 21:55:05     INFO -      eip = 0xf40e3195   esp = 0xffe0bf80   ebp = 0xffe0c228   ebx = 0xffe0c078
[task 2017-10-15T21:55:05.239Z] 21:55:05     INFO -      esi = 0x000000e7   edi = 0x00000000
[task 2017-10-15T21:55:05.240Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.241Z] 21:55:05     INFO -  18  0x498e0b6f
[task 2017-10-15T21:55:05.242Z] 21:55:05     INFO -      eip = 0x498e0b6f   esp = 0xffe0c230   ebp = 0xffe0c288   ebx = 0xffe0c250
[task 2017-10-15T21:55:05.243Z] 21:55:05     INFO -      esi = 0x498fc368   edi = 0xe96bdc08
[task 2017-10-15T21:55:05.244Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.245Z] 21:55:05     INFO -  19  0xe96bdc08
[task 2017-10-15T21:55:05.246Z] 21:55:05     INFO -      eip = 0xe96bdc08   esp = 0xffe0c290   ebp = 0xffe0c2fc
[task 2017-10-15T21:55:05.247Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.248Z] 21:55:05     INFO -  20  0x498d8bd6
[task 2017-10-15T21:55:05.249Z] 21:55:05     INFO -      eip = 0x498d8bd6   esp = 0xffe0c304   ebp = 0xffe0c328
[task 2017-10-15T21:55:05.250Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.251Z] 21:55:05     INFO -  21  libxul.so!js::jit::EnterBaselineAtBranch [BaselineJIT.cpp:237acf2879f6 : 156 + 0x5d]
[task 2017-10-15T21:55:05.252Z] 21:55:05     INFO -      eip = 0xf40c11fc   esp = 0xffe0c330   ebp = 0xffe0c538
[task 2017-10-15T21:55:05.253Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.254Z] 21:55:05     INFO -  22  libxul.so!Interpret [Interpreter.cpp:237acf2879f6 : 2023 + 0x16]
[task 2017-10-15T21:55:05.255Z] 21:55:05     INFO -      eip = 0xf3ffc61c   esp = 0xffe0c540   ebp = 0xffe0c858   ebx = 0x00000000
[task 2017-10-15T21:55:05.256Z] 21:55:05     INFO -      esi = 0xee928800   edi = 0xf761c000
[task 2017-10-15T21:55:05.258Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.259Z] 21:55:05     INFO -  23  libxul.so!js::RunScript [Interpreter.cpp:237acf2879f6 : 423 + 0x10]
[task 2017-10-15T21:55:05.260Z] 21:55:05     INFO -      eip = 0xf3ffca1c   esp = 0xffe0c860   ebp = 0xffe0c918   ebx = 0xee928800
[task 2017-10-15T21:55:05.261Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0xee97d014
[task 2017-10-15T21:55:05.262Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.263Z] 21:55:05     INFO -  24  libxul.so!js::ExecuteKernel [Interpreter.cpp:237acf2879f6 : 706 + 0x15]
[task 2017-10-15T21:55:05.264Z] 21:55:05     INFO -      eip = 0xf3fff042   esp = 0xffe0c920   ebp = 0xffe0c9d8   ebx = 0xffe0c98c
[task 2017-10-15T21:55:05.265Z] 21:55:05     INFO -      esi = 0xffe0c998   edi = 0xffe0c9a8
[task 2017-10-15T21:55:05.265Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.266Z] 21:55:05     INFO -  25  libxul.so!js::Execute [Interpreter.cpp:237acf2879f6 : 739 + 0x2a]
[task 2017-10-15T21:55:05.267Z] 21:55:05     INFO -      eip = 0xf3fff3ab   esp = 0xffe0c9e0   ebp = 0xffe0ca48   ebx = 0xf761c000
[task 2017-10-15T21:55:05.268Z] 21:55:05     INFO -      esi = 0xe982f800   edi = 0x00000000
[task 2017-10-15T21:55:05.269Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.270Z] 21:55:05     INFO -  26  libxul.so!Evaluate [jsapi.cpp:237acf2879f6 : 4808 + 0x14]
[task 2017-10-15T21:55:05.270Z] 21:55:05     INFO -      eip = 0xf4417223   esp = 0xffe0ca50   ebp = 0xffe0cb18   ebx = 0xee928800
[task 2017-10-15T21:55:05.271Z] 21:55:05     INFO -      esi = 0xf761c000   edi = 0xffe0ca88
[task 2017-10-15T21:55:05.272Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.273Z] 21:55:05     INFO -  27  libxul.so!JS::Evaluate [jsapi.cpp:237acf2879f6 : 4847 + 0x18]
[task 2017-10-15T21:55:05.274Z] 21:55:05     INFO -      eip = 0xf441745c   esp = 0xffe0cb20   ebp = 0xffe0cba8   ebx = 0xf761c000
[task 2017-10-15T21:55:05.275Z] 21:55:05     INFO -      esi = 0xffe0cd54   edi = 0xffe0cb78
[task 2017-10-15T21:55:05.276Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.276Z] 21:55:05     INFO -  28  libxul.so!XRE_XPCShellMain [XPCShellImpl.cpp:237acf2879f6 : 1001 + 0x27]
[task 2017-10-15T21:55:05.277Z] 21:55:05     INFO -      eip = 0xf198cb60   esp = 0xffe0cbb0   ebp = 0xffe0ce68   ebx = 0xf761c000
[task 2017-10-15T21:55:05.278Z] 21:55:05     INFO -      esi = 0x00000017   edi = 0xffe0e710
[task 2017-10-15T21:55:05.279Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.280Z] 21:55:05     INFO -  29  xpcshell!main [xpcshell.cpp:237acf2879f6 : 68 + 0x13]
[task 2017-10-15T21:55:05.281Z] 21:55:05     INFO -      eip = 0x0804d7a4   esp = 0xffe0ce70   ebp = 0xffe0cec8   ebx = 0x08076000
[task 2017-10-15T21:55:05.281Z] 21:55:05     INFO -      esi = 0xffe0cee0   edi = 0xee95a030
[task 2017-10-15T21:55:05.282Z] 21:55:05     INFO -      Found by: call frame info
[task 2017-10-15T21:55:05.283Z] 21:55:05     INFO -  30  libc-2.23.so + 0x18637
[task 2017-10-15T21:55:05.284Z] 21:55:05     INFO -      eip = 0xef97e637   esp = 0xffe0ced0   ebp = 0x00000000
[task 2017-10-15T21:55:05.285Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.286Z] 21:55:05     INFO -  31  libc-2.23.so + 0x1b2000
[task 2017-10-15T21:55:05.286Z] 21:55:05     INFO -      eip = 0xefb18000   esp = 0xffe0ced4   ebp = 0x00000000
[task 2017-10-15T21:55:05.287Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.288Z] 21:55:05     INFO -  32  libc-2.23.so + 0x1b2000
[task 2017-10-15T21:55:05.289Z] 21:55:05     INFO -      eip = 0xefb18000   esp = 0xffe0ced8   ebp = 0x00000000
[task 2017-10-15T21:55:05.290Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.291Z] 21:55:05     INFO -  33  libc-2.23.so + 0x18637
[task 2017-10-15T21:55:05.291Z] 21:55:05     INFO -      eip = 0xef97e637   esp = 0xffe0cee0   ebp = 0x00000000
[task 2017-10-15T21:55:05.292Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.293Z] 21:55:05     INFO -  34  libc-2.23.so + 0x1b2000
[task 2017-10-15T21:55:05.294Z] 21:55:05     INFO -      eip = 0xefb18000   esp = 0xffe0cefc   ebp = 0x00000000
[task 2017-10-15T21:55:05.295Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.295Z] 21:55:05     INFO -  35  libc-2.23.so + 0x1b2000
[task 2017-10-15T21:55:05.296Z] 21:55:05     INFO -      eip = 0xefb18000   esp = 0xffe0cf0c   ebp = 0x00000000
[task 2017-10-15T21:55:05.297Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.298Z] 21:55:05     INFO -  36  libc-2.23.so + 0x1b2000
[task 2017-10-15T21:55:05.299Z] 21:55:05     INFO -      eip = 0xefb18000   esp = 0xffe0cf10   ebp = 0x00000000
[task 2017-10-15T21:55:05.300Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.301Z] 21:55:05     INFO -  37  xpcshell + 0x59c8
[task 2017-10-15T21:55:05.301Z] 21:55:05     INFO -      eip = 0x0804d9c8   esp = 0xffe0cf30   ebp = 0x00000000
[task 2017-10-15T21:55:05.302Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.303Z] 21:55:05     INFO -  38  ld-2.23.so + 0x15030
[task 2017-10-15T21:55:05.304Z] 21:55:05     INFO -      eip = 0xf7772030   esp = 0xffe0cf38   ebp = 0x00000000
[task 2017-10-15T21:55:05.305Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.306Z] 21:55:05     INFO -  39  ld-2.23.so + 0xf8a0
[task 2017-10-15T21:55:05.306Z] 21:55:05     INFO -      eip = 0xf776c8a0   esp = 0xffe0cf3c   ebp = 0x00000000
[task 2017-10-15T21:55:05.307Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.308Z] 21:55:05     INFO -  40  xpcshell + 0x59c8
[task 2017-10-15T21:55:05.309Z] 21:55:05     INFO -      eip = 0x0804d9c8   esp = 0xffe0cf48   ebp = 0x00000000
[task 2017-10-15T21:55:05.310Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.311Z] 21:55:05     INFO -  41  xpcshell!_start + 0x21
[task 2017-10-15T21:55:05.311Z] 21:55:05     INFO -      eip = 0x0804d9e9   esp = 0xffe0cf50   ebp = 0x00000000
[task 2017-10-15T21:55:05.312Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.313Z] 21:55:05     INFO -  42  xpcshell!MOZ_ReportCrash [Assertions.h:237acf2879f6 : 183 + 0x7]
[task 2017-10-15T21:55:05.314Z] 21:55:05     INFO -      eip = 0x0804d731   esp = 0xffe0cf54   ebp = 0x00000000
[task 2017-10-15T21:55:05.315Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.316Z] 21:55:05     INFO -  43  xpcshell!__libc_csu_fini + 0x10
[task 2017-10-15T21:55:05.316Z] 21:55:05     INFO -      eip = 0x0806a560   esp = 0xffe0cf60   ebp = 0xffe0cf74
[task 2017-10-15T21:55:05.317Z] 21:55:05     INFO -      Found by: stack scanning
[task 2017-10-15T21:55:05.318Z] 21:55:05     INFO -  44  0xffe0e3d0
[task 2017-10-15T21:55:05.319Z] 21:55:05     INFO -      eip = 0xffe0e3d0   esp = 0xffe0cf7c   ebp = 0xffe0e394
[task 2017-10-15T21:55:05.320Z] 21:55:05     INFO -      Found by: previous frame's frame pointer
[task 2017-10-15T21:55:05.321Z] 21:55:05     INFO -  45  0x2f73646c
[task 2017-10-15T21:55:05.321Z] 21:55:05     INFO -      eip = 0x2f73646c   esp = 0xffe0e39c   ebp = 0x6975622f
[task 2017-10-15T21:55:05.322Z] 21:55:05     INFO -      Found by: previous frame's frame pointer

Comment 5

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/28a28f017a5f8be72f91b3efb4e820abd16b949c
Bug 1407428: Hand out a const array reference for expanded principal whiteList. r=krizsa

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/28a28f017a5f