Closed Bug 1407468 Opened 2 years ago Closed 2 years ago

Tie some build items to toolkit

Categories

(Firefox Build System :: General, enhancement)

enhancement
Not set

Tracking

(firefox58 fixed)

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: glandium, Assigned: glandium)

Details

(Whiteboard: [stockwell fixed:other])

Attachments

(3 files)

The ultimate goal here is to allow to build smaller parts of the tree with configure --enable-project=foo. For instance, currently, configure ends up running js/src/configure, which is unnecessary unless you build toolkit (or js standalone, but in that case, js/src/configure is just invoked directly).
Comment on attachment 8917213 [details]
Bug 1407468 - Only enable necko-wifi by default when toolkit is built.

https://reviewboard.mozilla.org/r/188230/#review193688

::: old-configure.in:4441
(Diff revision 1)
>  MOZ_ARG_DISABLE_BOOL(necko-wifi,
>  [  --disable-necko-wifi    Disable necko wifi scanner],
>      NECKO_WIFI=,
>      NECKO_WIFI=1)
>  
> -if test "$NECKO_WIFI"; then
> +if test "$NECKO_WIFI" -a "$MOZ_WIDGET_TOOLKIT"; then

I think you want the MOZ_WIDGET_TOOLKIT check on the next if to just avoid the error message (or potentially, disable NECKO_WIFI entirely if MOZ_WIDGET_TOOLKIT isn't set). As it is, if you have NECKO_WIFI=1 and no MOZ_WIDGET_TOOLKIT, you'll end up with NECKO_WIFI=1 in substs but no NECKO_WIFI in defines.
Attachment #8917213 - Flags: review?(mshal)
Comment on attachment 8917215 [details]
Bug 1407468 - Replace multiple !JS_STANDALONE with MOZ_WIDGET_TOOLKIT.

https://reviewboard.mozilla.org/r/188234/#review193690
Attachment #8917215 - Flags: review?(mshal) → review+
Comment on attachment 8917214 [details]
Bug 1407468 - Only build js/src when building toolkit.

https://reviewboard.mozilla.org/r/188232/#review193692

::: old-configure.in:5031
(Diff revision 1)
>    AC_OUTPUT_SUBDIRS_NOW("$_subconfigure_subdir",$cache_file)
>    ac_configure_args="$_save_ac_configure_args"
>    srcdir="$_save_srcdir"
>  fi
>  
> -if test "$COMPILE_ENVIRONMENT"; then
> +if test "$COMPILE_ENVIRONMENT" -a "$MOZ_WIDGET_TOOLKIT"; then

Does the moz.build recursion need to match?

https://dxr.mozilla.org/mozilla-central/rev/a0488ecc201c04f2617e7b02f039344e8fbf0d9a/moz.build#104
Attachment #8917214 - Flags: review?(mshal) → review+
Attachment #8917214 - Flags: review+ → review?(mshal)
Comment on attachment 8917214 [details]
Bug 1407468 - Only build js/src when building toolkit.

https://reviewboard.mozilla.org/r/188232/#review194190
Attachment #8917214 - Flags: review?(mshal) → review+
Comment on attachment 8917213 [details]
Bug 1407468 - Only enable necko-wifi by default when toolkit is built.

https://reviewboard.mozilla.org/r/188230/#review194188
Attachment #8917213 - Flags: review?(mshal) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/42d708dc85fc
Only enable necko-wifi by default when toolkit is built. r=mshal
https://hg.mozilla.org/integration/autoland/rev/e07a025fdc8f
Only build js/src when building toolkit. r=mshal
https://hg.mozilla.org/integration/autoland/rev/84946a59ea8a
Replace multiple !JS_STANDALONE with MOZ_WIDGET_TOOLKIT. r=mshal
This change broke the tryselect task and likely also several python unittest tasks:
https://treeherder.mozilla.org/#/jobs?repo=autoland&tochange=84946a59ea8a5fae6d77053c5dc8b94ecf2e16e2&fromchange=d0e32dc8a141c9d344c1a15c38dad1790ccdc770&filter-searchStr=try

It broke due to this change:
https://hg.mozilla.org/mozilla-central/rev/84946a59ea8a#l5.13

The reason is that the PYTHON_UNITTEST_MANIFEST variable defined under there, as well as the CRAMTEST_MANIFEST variable defined in tools/moz.build needs to be:

1. Picked up without an objdir
2. Not run with JS_STANDALONE

Putting them behind MOZ_WIDGET_TOOLKIT means the relevant tests aren't found and the tasks fail in automation. We should also add the root moz.build file to these tasks' when.files-changed variable in taskcluster so they get run when this file is modified in the future.
Flags: needinfo?(mh+mozilla)
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/mozilla-inbound/rev/873e2f3a9cf5
Fixup for cramtests and some python tests after bug 1407468. r=me
Flags: needinfo?(mh+mozilla)
There have been no failures since the fix was pushed (13-14 Oct).
Whiteboard: [stockwell fixed:other]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.