Closed
Bug 1407548
Opened 7 years ago
Closed 7 years ago
cache l10n values in request-list-empty-notice
Categories
(DevTools :: Netmonitor, enhancement, P3)
Tracking
(firefox57 fix-optional, firefox58 fixed)
RESOLVED
FIXED
Firefox 58
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fix-optional |
| firefox58 | --- | fixed |
People
(Reporter: gasolin, Assigned: pradeepgangwar, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][mentor-lang=zh][lang=js])
Attachments
(1 file)
as bug 1404130 we found L10N APIs has high cost so we'd like cache as much strings in each component as possible you can refer the `mdn-link` component, define L10N strings as `const` like http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/mdn-link.js#17
|
Reporter | |
Updated•7 years ago
|
|
Assignee | |
Comment 1•7 years ago
|
||
I referred the file given in link. But I didn't find any L10N string other than in line 17. Can I get more details about the file(s) which needs modification.
Flags: needinfo?(gasolin)
|
|
Reporter | |
Comment 2•7 years ago
|
||
Pradeep, please take a look on request-list-empty-notice.js, not mdn-link.js http://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/request-list-empty-notice.js#52
Flags: needinfo?(gasolin)
|
|
Assignee | |
Comment 3•7 years ago
|
||
Thanks! Can you assign this to me. I will be happy to work on this.
Flags: needinfo?(gasolin)
|
|
Reporter | |
Updated•7 years ago
|
Assignee: nobody → pradeepgangwar39
Flags: needinfo?(gasolin)
|
|
Reporter | |
Updated•7 years ago
|
Keywords: good-first-bug
|
||
Updated•7 years ago
|
status-firefox57:
--- → fix-optional
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
|
Reporter | |
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8917539 [details] Bug 1407548- Cache L10N values in request-list-empty-notice; https://reviewboard.mozilla.org/r/188504/#review193952 looks good, let's see how auto test goes. Thanks for contribution!
Attachment #8917539 -
Flags: review?(gasolin) → review+
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 7•7 years ago
|
||
After seeing many test failing I was able to figure what caused it. I missed a ')' in Line 62. I request you to re-test the patch. Sorry for the inconvenience caused.
Flags: needinfo?(gasolin)
|
|
Reporter | |
Comment 8•7 years ago
|
||
Thanks for the update! Triggered another test.
Flags: needinfo?(gasolin)
|
|
Assignee | |
Comment 9•7 years ago
|
||
Sir, I need help regarding what caused test failure. I am unable to figure out.
Flags: needinfo?(gasolin)
|
||
Comment 10•7 years ago
|
||
Pushed by flin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/dfb2cb2683f1 Cache L10N values in request-list-empty-notice; r=gasolin
|
|
Reporter | |
Comment 11•7 years ago
|
||
Thanks for keep tracking the progress, the error in Tree herder said it's an intermittent and seems not related to this bug, so this bug is ready to land :)
Flags: needinfo?(gasolin)
|
||
Comment 12•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/dfb2cb2683f1
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox58:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 58
|
||
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•