1407601 - Bug 1389965 breaks linux and solaris build

Status: RESOLVED FIXED

(Core :: Memory Allocator, defect)

Description

[Andrea Marchesini [:baku]]

xpcshell crashes because of a loop like this:

#1184 0x000000000040638f in moz_xmalloc (size=40) at /home/baku/Sources/m/streams/src/memory/mozalloc/mozalloc.cpp:84
#1185 0x00007f4cdaa946d5 in malloc (size=40) at /home/baku/Sources/m/streams/src/gfx/graphite2/src/MozGrMalloc.h:17
#1186 0x000000000040638f in moz_xmalloc (size=40) at /home/baku/Sources/m/streams/src/memory/mozalloc/mozalloc.cpp:84
#1187 0x00007f4cdaa946d5 in malloc (size=40) at /home/baku/Sources/m/streams/src/gfx/graphite2/src/MozGrMalloc.h:17

Comment 1

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Solaris is a compiler break as described in https://bugzilla.mozilla.org/show_bug.cgi?id=1389965#c15

Comment 2

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Is there a way to reproduce this? It doesn't break the xpshell tests on Taskcluster: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2131c443d4c53fee78bf40d15684fdc8579a681d&selectedJob=136227676

Comment 3

[Andrea Marchesini [:baku]]

I can reproduce it locally constantly. This is my mozconfig:

mk_add_options MOZ_MAKE_FLAGS="-j4 -s"
ac_add_options --with-ccache=/usr/bin/ccache
ac_add_options --enable-debug
ac_add_options --disable-optimize
ac_add_options --disable-jemalloc

gcc version 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4)

Comment 4

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Attachment: Bug 1407601 Revert to the previous behavior in MozGrMalloc.h for Linux, and add extern C to correct Solaris build break

Review commit: https://reviewboard.mozilla.org/r/188542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/188542/

Comment 5

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

I will have to investigate this next week, although setting up an environment could be tricky. But I attached a patch needed for Solaris. If this fixes it for you that would be awesome. If not, I will have to revert to an ifdef I suppose.

Comment 6

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Hey baku - I seemed to reproduce your dev environment, but I can't get `./mach test xpcshell` to not throw errors even on a version that undoes the #define -> inline function patch.  Would you be able to test the attached patch on this bug and see if it resolves the xpcshell break? If not, we'll #ifdef a case for linux I suppose.

Comment 7

[Andrea Marchesini [:baku]]

It doesn't fix the issue. I still see xpcshell crashing all the time.

Comment 8

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Comment on attachment 8917575 [details]
Bug 1407601 Revert to the previous behavior in MozGrMalloc.h for Linux, and add extern C to correct Solaris build break

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/188542/diff/1-2/

Comment 9

[Tom Ritter [:tjr] (OOTO until 4/30 at least)]

Okay, I ifdef for Linux. If the attached patch works for you and looks good we can button this up for both you and Solaris.

Comment 10

[Andrea Marchesini [:baku]]

Comment on attachment 8917575 [details]
Bug 1407601 Revert to the previous behavior in MozGrMalloc.h for Linux, and add extern C to correct Solaris build break

https://reviewboard.mozilla.org/r/188542/#review197936

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f9a79521c24
Revert to the previous behavior in MozGrMalloc.h for Linux, and add extern C to correct Solaris build break r=baku

Comment 12

[Attila Craciun [:arny]]

https://hg.mozilla.org/mozilla-central/rev/9f9a79521c24