1407605 - Clean and sweep in nsHttpChannel

Status: NEW

(Core :: Networking: HTTP, enhancement, P3)

Description

[Honza Bambas (:mayhemer)]

This bug is a bit of a long term project :)

Reading the code of this fundamental class becomes more and more complicated.  The connect phase (before we start the transaction) is so much broke into small pieces and async callbacks it's hard to keep track and catch potential issues when the code is being change.  I'd like to try to clean it a bit as:

- Unify the Continue* and After* and *Actual etc method naming to something that can be read and easily understood
- Try to sort the code in the way as it is likely to be executed (to be able to read it as a book, kinda..)
- Whatever else comes to mind to clean this up

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Cleaning up error paths would be helpful.  AFAICT there are right now:

* Cancel()
* AsyncAbort()
* mStatus=aRv + DoNotifyListener()

Some of these have de-duplication code and some do not.

Its very confusing about what is supposed to be called when.  In InterceptedHttpChannel I chose to make everything go through Cancel() for consistency.