Closed Bug 1407640 Opened 7 years ago Closed 6 years ago

wr-text: linux vertical snaps some glyphs one pixel off

Categories

(Core :: Graphics: WebRender, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
Tracking Status
firefox58 --- affected

People

(Reporter: Gankra, Assigned: lsalzman)

References

Details

(Whiteboard: [wr-reserve])

Just a bunch of loose tests that fail as a result -- seems diacritic-ish related?

https://hg.mozilla.org/try/rev/e7ddc6a41512a4777a71a9e8cddae74cbdc408d0
Whiteboard: [wr-mvp] [triage]
Priority: -- → P2
Whiteboard: [wr-mvp] [triage] → [wr-mvp]
It looks like these failures are just comparing fallback text to native text, and somehow we're messing up the fallback a bit?

https://bugzilla.mozilla.org/show_bug.cgi?id=1407767 fixes half of them. The remaining failures are:

Only 4 failures remain.



3 are vertical-lr/rl fallback:

layout/reftests/font-features/reftest.list
== 1376231-vertical-gpos-adjustments.html 1376231-vertical-gpos-adjustments-ref.html

layout/reftests/w3c-css/received/reftest.list
== css-writing-modes-3/text-combine-upright-decorations-001.html css-writing-modes-3/reference/text-combine-upright-decorations-001.html

layout/reftests/writing-mode/reftest.list
== 1111944-1-list-marker.html 1111944-1-list-marker-ref.html



1 is tofu:

layout/reftests/bidi/reftest.list
== 612843-1.html 612843-1-ref.html
Since we already have bugs for implementing those features, I suggest closing this issue in favor of those.

What do you think, kats?
Flags: needinfo?(bugmail)
Tofu glyphs are bug 1400917, which bug covers the vertical-lr/rl stuff? But yeah if these are covered in other bugs I'm ok with closing this out.
Flags: needinfo?(bugmail)
Priority: P2 → P3
Whiteboard: [wr-mvp] → [wr-reserve]
lee demolished all the linux text issues months ago
Assignee: nobody → lsalzman
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.