1407722 - Don't use named colour resources provided by the framework

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, enhancement, P5)

Description

[Jan Henning [:JanH]]

It turns out [1] that using e.g. "@android:color/white" respectively "android.R.color.white" doesn't actually guarantee you're getting #FFFFFF in the end because the device manufacturer might have decided to use a different colour for "white" (or worse, @android:color/transparent turns out to not actually be transparent after all).

So we should go through [2] and [3] and replace them with our own colour definitions if we want to be sure to use the same colours everywhere all the time.

[1] https://twitter.com/mandybess/status/910555678476951552
[2] https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile+android.R.color&redirect=false
[3] https://dxr.mozilla.org/mozilla-central/search?q=path%3Amobile+android+%22android%3Acolor%2F%22&redirect=false

Comment 1

[Firefox Bug Husbandry Bot]

Re-triaging per https://bugzilla.mozilla.org/show_bug.cgi?id=1473195

Needinfo :susheel if you think this bug should be re-triaged.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.