1407775 - Improve the layout and info in the job filters bar

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

I thought I'd try to improve a few little things in the job filters bar:

1) Pass the full filter.value into a tooltip to support long filter strings, which are truncated at 12 chars and otherwise unreadable

2) Vertically align the "Active Filters" title with the adjacent filter spans, as it was a bit misaligned on prod

3) Make the filters delete on only the [x] icon, not the whole string

4) Align the left side of these filter contents with the related push contents below it

5) Format each filter with some bold for readability of the field vs. the value

Comment 1

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:filterbar-improvements > mozilla:master

Comment 2

[Jonathan French (:jfrench)]

Comment on attachment 8917561 [details] [review]
[treeherder] tojon:filterbar-improvements > mozilla:master

Note this PR has my yarn.lock file which underwent changes due to a normal yarn update, as discussed on IRC. Let me know if anything needs to be done regarding that.

Comment 3

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/6c9348beb00a663b6679ecc320adb4ebf724e5b8
Bug 1407775 - Improve the layout and info in the job filters bar

Comment 4

[Ed Morley [:emorley]]

(In reply to Jonathan French (:jfrench) from comment #2)
> Note this PR has my yarn.lock file which underwent changes due to a normal
> yarn update, as discussed on IRC. Let me know if anything needs to be done
> regarding that.

This can happen if the yarn versions differ. I think the best way to handle for the future is to discard any local changes before pushing to avoid churn (unless the PR is actually adjusting the packages in package.json). Newer versions of yarn have various fixes to avoid such churn.

Comment 5

[Jonathan French (:jfrench)]

Ok, sounds good.

Comment 6

[Jonathan French (:jfrench)]

Verified fixed on production.