1407807 - Remove Tier as a choice from the job filter field dropdown

Status: VERIFIED FIXED

(Tree Management :: Treeherder, defect, P4)

Description

[Jonathan French (:jfrench)]

Maybe this is pilot error, but here's the steps to reproduce:

o Launch production
o Click on the new "filter by job field" icon in the navbar
o Select from the filter field drop down, "Tier"
o Enter either "1" or "2" into the adjacent input field
o Click the Add button

Expected:
Some sort of filtering on the Tier value.

Observed:
The Filter bar disappears.

Optionally, try this:
o Select filter field dropdown "Tier"
o Enter "a", or any other alphabetic character
o Click the Add button

Observed:
"Tier"s "1", "2", and "a" get added. So you have Active Filters: "Tier 1" "Tier 2" and "Tier a".

If Tier is a restricted type of value, I would have thought the UI would only present a drop down of specific choices? Like it does when filtering by the Failure Classification drop down.

Comment 1

[Cameron Dawson [:camd]]

Good find.  We should just remove Tier from the list of field filters we accept.  It's redundant anyway.  So it could be removed from https://github.com/mozilla/treeherder/blob/master/ui/js/services/jobfilters.js#L104

That should just eliminate the problem.  :)

Comment 2

[Jonathan French (:jfrench)]

I had a quick look at this. Pulling only that element in the array results in a console error, perhaps related to the filter cache which is still expecting tier. So there might be some additional tweak here.

Comment 3

[Cameron Dawson [:camd]]

ahh, you're right.  Since it has a default value, it can't just be removed.  we'll have to add a mechanism to just hide it from the dropdown.  maybe adding another field to that FIELD_CHOICES object.  Or by some other mechanism.

Comment 4

[Jonathan French (:jfrench)]

I think can do it in one line with an ng-if in the markup. Or with a generalized solution as you say by adding multiple new lines for the new field eg. 'shouldShow' to the FIELD_CHOICES object. I'll put up a PR with the first way, since it is a one-off exclusion at present and you can let me know your preference.

Comment 5

[GitHub Autolander Bot]

Attachment: [treeherder] tojon:suppress-invalid-jobfilters > mozilla:master

Comment 6

[Jonathan French (:jfrench)]

Comment on attachment 8918389 [details] [review]
[treeherder] tojon:suppress-invalid-jobfilters > mozilla:master

For review/merge at your leisure. :)

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/df56f2c4c4e79f419f183826f9d7682d5788954e
Bug 1407807 - Remove Tier as a choice from the job filter field dropdown

Comment 8

[Jonathan French (:jfrench)]

Verified fixed on production.